If we are doing this then maybe we should add a remove category function too?

Moved page out of drafts. New link is https://www.mediawiki.org/wiki/Manual:Pywikibot/Pywikibot_and_PAWS. I also updated the links to the old notebook mentioned in the original write-up for this. I searched for other links but did not find any. If new page is approved, this can be closed out.

In T346417#9389468, @Xqt wrote:

In T346417#9389162, @Enag2000 wrote:

In T346417#9387794, @Xqt wrote:

@Enag2000: Could you please provide a command line wich produces this exception above for CR

Yes. Running the following on English Wikipedia will produce the exception seen above. This assumes that the directory "InvalidDirectory" does not exist.

pwb.py -v category_graph -from Equations -to InvalidDirectory\Equations

But your patch does not solve that:

D:\pwb\GIT\core>pwb.py  -simulate category_graph -from Equations -to InvalidDirectory\Equations
Scanning 'Equations'
Saving results
InvalidDirectory\Equations.gv
Traceback (most recent call last):
  File "D:\pwb\GIT\core\pwb.py", line 39, in <module>
    sys.exit(main())
             ^^^^^^
  File "D:\pwb\GIT\core\pwb.py", line 35, in main
    runpy.run_path(str(path), run_name='__main__')
  File "<frozen runpy>", line 291, in run_path
  File "<frozen runpy>", line 98, in _run_module_code
  File "<frozen runpy>", line 88, in _run_code
  File "D:\pwb\GIT\core\pywikibot\scripts\wrapper.py", line 515, in <module>
    main()
  File "D:\pwb\GIT\core\pywikibot\scripts\wrapper.py", line 499, in main
    if not execute():
           ^^^^^^^^^
  File "D:\pwb\GIT\core\pywikibot\scripts\wrapper.py", line 486, in execute
    run_python_file(filename, script_args, module)
  File "D:\pwb\GIT\core\pywikibot\scripts\wrapper.py", line 147, in run_python_file
    exec(compile(source, filename, 'exec', dont_inherit=True),
  File "D:\pwb\GIT\core\scripts\category_graph.py", line 230, in <module>
    bot.run()
  File "D:\pwb\GIT\core\scripts\category_graph.py", line 184, in run
    self.dot.write(self.to + '.gv', encoding='utf-8')
  File "C:\Python311\Lib\site-packages\pydot.py", line 1825, in write
    with io.open(path, mode='wt', encoding=encoding) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'InvalidDirectory\\Equations.gv'
CRITICAL: Exiting due to uncaught exception FileNotFoundError: [Errno 2] No such file or directory: 'InvalidDirectory\\Equations.gv'

In T346417#9387794, @Xqt wrote:

@Enag2000: Could you please provide a command line wich produces this exception above for CR

The draft has been completed, pending a few minor formatting edits. If approved, I will move it out of drafts so that it is visible on Wikimedia.

Under this change, commands like -log and -nolog will be applied to both the wrapper and the bot script to be run. If that is not desired, I can do another patchset.

Deactivation to be completed as part of T328900.

It looks like this has already been fixed in bot.py. It is now optional via the -nolog file.

See related issue T328900.

In looking at this one, it seems like there is an issue with how arguments are handled. If -nolog is included as a global argument before the name of the script, then the wrapper handles -nolog as part of its arguments and it does not carry over into logstat.py. If -nolog is included as a local argument (after logstat.py in arguments), then logstat.py is not logged to the command log because -nolog is applied.

Link to current draft. https://www.mediawiki.org/wiki/Manual:Pywikibot/Draft:Pywikibot_and_PAWS

Code check passed. Still awaiting completion of code review.

The string where the scanned category is logged is not a format string. The proposed solution is to format the string. This will ensure that {cat_title!r} is replaced with the correct category.

I again accidentally submitted for review twice. My mistake.

I see now that it actually is replaced with the line 'This script supports use of pagegenerators arguments.' My mistake. I can close this one.

Code review complete. Jenkins build succeeded and change merged. Moving to "Resolved".

Accidentally submitted for review twice. My mistake. I just looked at the Gerrit/Tutorial on MediaWiki and understand the correct process now.

Didn't realize that including the exact commit number automatically adds a mention to other tasks. When documenting the version of pywikibot that a bug occured on, is just "pywikibot core master" or similar acceptable?

Working on this as a new contributor due to it being tagged "good first task".