Page MenuHomePhabricator

MatthiasDD (Matthias)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 16 2014, 6:41 PM (260 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
MatthiasDD [ Global Accounts ]

Recent Activity

Apr 15 2018

MatthiasDD added a comment to T46818: jquery.tablesorter should sort plain year digits as date.

We should discuss if we need really:

  1. guesstimate centurys (read year 70 as 1970). This is problematic with old years and can imho abandoned.
  2. Year BC detection. It's difficult to test it in all languages. I have used the wikidata object Q39085.
  3. Variable yearBC is stored in mw.language.data because it is language specific. We can use later wgUserLanguage instead of wgPageContentLanguage? Used variable wgDefaultDateFormat and tableSorterCollation is stored in mw.config - why? (RFC)

I'm write now some tests for jquery.tablesorter.test.js.

Apr 15 2018, 11:06 AM · Patch-For-Review, MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface

Mar 7 2018

MatthiasDD claimed T46818: jquery.tablesorter should sort plain year digits as date.

I'm working on the date parser. I think we need a language setting like mw.language.months.names for BC era to detect years before year 0.

Mar 7 2018, 10:31 PM · Patch-For-Review, MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface

Jan 20 2018

MatthiasDD closed T180142: Table sorting is wrong on several projects (Danish, Norwegian Nynorsk, Norwegian Bokmål) as Resolved.
Jan 20 2018, 11:09 PM · MediaWiki-jQuery-Tablesorter

Jan 7 2018

MatthiasDD added a comment to T180142: Table sorting is wrong on several projects (Danish, Norwegian Nynorsk, Norwegian Bokmål).

... oh sorry, i have tested with an older version offline. We can transform more than one letter ("aa" into "å") since Aug 2016.
But the tableSorterCollation shoud contain only lowercase letters. He work after

s = $.trim( s.toLowerCase() );
if ( ts.collationRegex ) { ...
Jan 7 2018, 4:32 PM · MediaWiki-jQuery-Tablesorter

Jan 6 2018

MatthiasDD added a comment to T180142: Table sorting is wrong on several projects (Danish, Norwegian Nynorsk, Norwegian Bokmål).

In Norway is since Nov. 2017 a tableSorterCollation in Common.js, in Nynorsk (nn:), Islandic (is:) also. Danish (da:) and Faroese (fo:) Wikipedia have this not yet.
But the difficult task is to transform "aa" into "å". Today we can replace only one letter with one (or more) letter. Need we this really?
w:no:Spezial:All pages from "Saa.." sort 'aa' normal after 'a'.

Jan 6 2018, 5:30 PM · MediaWiki-jQuery-Tablesorter

Aug 20 2017

MatthiasDD closed T155187: QUnit test "jquery.tablesorter.parsers: ISO Dates" fails in Firefox as Resolved.

This task is now resolved with Change 287449 jquery.tablesorter: Improve detection and handling of isoDate.
Because the parser isoDate build the date instead with new Date("...")
now with isodate.setUTCHours(h,m,s,ms).

Aug 20 2017, 10:10 AM · Browser-Support-Firefox, MediaWiki-jQuery-Tablesorter

May 28 2016

MatthiasDD added a comment to T114607: jQuery.makeCollapsible not compatible with jquery.tablesorter.

I have tested the combination "sortable" and "mw-collapsible" and found only mistake if the header have more than one row and tfooter used.
If no caption written the script hides only the tbody, that is not enough.

May 28 2016, 10:14 PM · Patch-For-Review, MediaWiki-jQuery-Tablesorter, JavaScript
MatthiasDD added a member for MediaWiki-jQuery-Tablesorter: MatthiasDD.
May 28 2016, 7:40 AM

Feb 14 2016

MatthiasDD added a comment to T126886: Tablesorter not sorting certain columns in Firefox & Safari.

Firefox needs a "T" in strings for isoDate:

new Date( "2010-02-06T19:12:00" ).toISOString();

is ok.
I have a solution for this - but it's today not ready for commit. See mw:Tablesorter/Improved parsers ...

Feb 14 2016, 10:08 PM · MW-1.30-release-notes, User-notice, Browser-Support-Apple-Safari, Browser-Support-Firefox, MediaWiki-jQuery-Tablesorter

Jan 5 2016

MatthiasDD triaged T122214: Rowspan get lost on sortable tables as Normal priority.

This ins not a bug. Before sorting rowspanned cells must split into multiple cells with same content.
We can think about in this case - all rows are rowspanned - that after sorting the rowspan will restore to table.

Jan 5 2016, 11:04 AM · MediaWiki-jQuery-Tablesorter

Oct 10 2015

MatthiasDD added a comment to T114721: Table sorting broken by use of expand-child class.

In the past cssChildRows are read for auto detection of parser only for the first row. Now cssChildRows are scipped for auto detection and sorting.
After change I5180296 i have tested the example in https://en.wikipedia.org/wiki/Help:Sorting#Keeping some rows together. But this example have only text in the first row and in this case the second row was not read.

Oct 10 2015, 11:00 PM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)), MediaWiki-jQuery-Tablesorter

Aug 30 2015

MatthiasDD added a comment to T42618: jquery.tablesorter: Add support for a "fixed" column of row numbers..

A good patch, it works good for ltr- and rtl-direction. But why starts the classname with mw- ? I suggesst use of "autonumber" instesd "mw-autonumber". Every user read this HTML-code in the wiki-editor. It should be simple and short. For the counter i suggest use of "row":

table.autonumber tr td:first-child:before {

counter-increment: row;
content: counter(row);
}

Aug 30 2015, 9:49 PM · MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface

Aug 8 2015

MatthiasDD closed T30241: Proposal for ability to move sort icon for tables with "colspan"-ed/"rowspan"-ed header rows as Resolved.

Thee reason is, that bud0011 used | instead ! and so no <TH> generated. The function buildHeaders() use in headers the last row with the most columns.

Aug 8 2015, 10:58 AM · MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface
MatthiasDD closed T30241: Proposal for ability to move sort icon for tables with "colspan"-ed/"rowspan"-ed header rows, a subtask of T33601: [DO NOT USE] jquery-tablesorter (tracking) [superseded by #MediaWiki-jQuery-Tablesorter], as Resolved.
Aug 8 2015, 10:58 AM · MediaWiki-jQuery-Tablesorter, Tracking-Neverending

Aug 2 2015

Restricted Application updated subscribers of T74534: Table sorting broken by colspan.

I have worked on this problem and have a solution comming soon, after check some other problems with colspanning/rowspanning.

Aug 2 2015, 12:01 PM · WMF-deploy-2015-09-15_(1.26wmf23), MW-1.26-release, MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface

Mar 3 2015

MatthiasDD committed rODBY5a7f742c115c: File Uploads pass --upload-file fileTag=/path/to/file as an argument and set… (authored by MatthiasDD).
File Uploads pass --upload-file fileTag=/path/to/file as an argument and set…
Mar 3 2015, 8:38 PM
MatthiasDD committed rODBYe4a374185b9d: Comment out shebang (authored by MatthiasDD).
Comment out shebang
Mar 3 2015, 8:38 PM