Change Details

This service takes a `Language` argument, and it’s not obvious that it’s always the user language (in several methods it’s called with a `Language` which that method itself receives, e.g. as a hook argument in WikibaseCirrusSearch’s `Hooks::amendSearchResults()`), so I think have want to turn this into a “factory factory” – either the service is a callable taking a `Language` and returning an `EntityLinkFormatterFactory`, or we define a proper class/interface for that.

This service takes a `Language` argument, and it’s not obvious that it’s always the user language (in several methods it’s called with a `Language` which that method itself receives, e.g. as a hook argument in WikibaseCirrusSearch’s `Hooks::amendSearchResults()`), so I think we’ll have to turn this into a “factory factory” – either the service is a callable taking a `Language` and returning an `EntityLinkFormatterFactory`, or we define a proper class/interface for that.

This service takes a `Language` argument, and it’s not obvious that it’s always the user language (in several methods it’s called with a `Language` which that method itself receives, e.g. as a hook argument in WikibaseCirrusSearch’s `Hooks::amendSearchResults()`), so I think have wantwe’ll have to turn this into a “factory factory” – either the service is a callable taking a `Language` and returning an `EntityLinkFormatterFactory`, or we define a proper class/interface for that.