Page MenuHomePhabricator

Move WikibaseRepo EntityLinkFormatterFactory to service container
Closed, ResolvedPublic

Description

This service takes a Language argument, and it’s not obvious that it’s always the user language (in several methods it’s called with a Language which that method itself receives, e.g. as a hook argument in WikibaseCirrusSearch’s Hooks::amendSearchResults()), so I think we’ll have to turn this into a “factory factory” – either the service is a callable taking a Language and returning an EntityLinkFormatterFactory, or we define a proper class/interface for that.

Event Timeline

Change 681436 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681436

Change 681438 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681438

Change 681440 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681440

Change 681449 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Prepare to move language paramter from costructor to method...

https://gerrit.wikimedia.org/r/681449

Change 681450 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Prepare to move language paramter from costructor to method...

https://gerrit.wikimedia.org/r/681450

Change 681451 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo EntityLinkFormatterFactory to service container

https://gerrit.wikimedia.org/r/681451

Change 681454 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityLinkFormatterFactory() to static

https://gerrit.wikimedia.org/r/681454

Change 681455 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::getEntityLinkFormatterFactory() to static

https://gerrit.wikimedia.org/r/681455

Change 681616 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Skip OpenSearchLabelsTest::testOpenSearch

https://gerrit.wikimedia.org/r/681616

Change 681450 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Prepare to move language paramter from costructor to method...

https://gerrit.wikimedia.org/r/681450

Change 681449 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Prepare to move language paramter from costructor to method...

https://gerrit.wikimedia.org/r/681449

Change 681436 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681436

Change 681440 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681440

Change 681438 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681438

Change 681616 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Skip OpenSearchLabelsTest::testOpenSearch

https://gerrit.wikimedia.org/r/681616

Change 681451 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo EntityLinkFormatterFactory to service container

https://gerrit.wikimedia.org/r/681451

Change 681455 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::getEntityLinkFormatterFactory() to static

https://gerrit.wikimedia.org/r/681455

Change 681454 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityLinkFormatterFactory() to static

https://gerrit.wikimedia.org/r/681454