Page MenuHomePhabricator
Create Task
Maniphest T280501

Move WikibaseRepo EntityLinkFormatterFactory to service container
Closed, ResolvedPublic
Actions

Description

This service takes a Language argument, and it’s not obvious that it’s always the user language (in several methods it’s called with a Language which that method itself receives, e.g. as a hook argument in WikibaseCirrusSearch’s Hooks::amendSearchResults()), so I think we’ll have to turn this into a “factory factory” – either the service is a callable taking a Language and returning an EntityLinkFormatterFactory, or we define a proper class/interface for that.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 19 2021, 9:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2021, 9:58 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 19 2021, 9:58 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 20 2021, 12:04 PM
ItamarWMDE claimed this task.Apr 20 2021, 1:57 PM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 20 2021, 4:37 PM

Change 681436 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681436

gerritbot added a project: Patch-For-Review.Apr 20 2021, 4:37 PM
gerritbot added a comment.Apr 20 2021, 4:42 PM

Change 681438 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681438

gerritbot added a comment.Apr 20 2021, 4:50 PM

Change 681440 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681440

gerritbot added a comment.Apr 20 2021, 5:47 PM

Change 681449 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Prepare to move language paramter from costructor to method...

https://gerrit.wikimedia.org/r/681449

gerritbot added a comment.Apr 20 2021, 5:57 PM

Change 681450 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Prepare to move language paramter from costructor to method...

https://gerrit.wikimedia.org/r/681450

gerritbot added a comment.Apr 20 2021, 6:01 PM

Change 681451 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo EntityLinkFormatterFactory to service container

https://gerrit.wikimedia.org/r/681451

gerritbot added a comment.Apr 20 2021, 6:19 PM

Change 681454 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityLinkFormatterFactory() to static

https://gerrit.wikimedia.org/r/681454

gerritbot added a comment.Apr 20 2021, 6:20 PM

Change 681455 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::getEntityLinkFormatterFactory() to static

https://gerrit.wikimedia.org/r/681455

gerritbot added a comment.Apr 21 2021, 10:51 AM

Change 681616 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Skip OpenSearchLabelsTest::testOpenSearch

https://gerrit.wikimedia.org/r/681616

gerritbot added a comment.Apr 21 2021, 10:53 AM

Change 681450 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Prepare to move language paramter from costructor to method...

https://gerrit.wikimedia.org/r/681450

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 11:00 AM
ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 21 2021, 11:27 AM
gerritbot added a comment.Apr 21 2021, 11:33 AM

Change 681449 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Prepare to move language paramter from costructor to method...

https://gerrit.wikimedia.org/r/681449

gerritbot added a comment.Apr 21 2021, 11:48 AM

Change 681436 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681436

gerritbot added a comment.Apr 21 2021, 11:48 AM

Change 681440 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681440

gerritbot added a comment.Apr 21 2021, 6:10 PM

Change 681438 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Stop passing Language into EntityLinkFormatterFactory

https://gerrit.wikimedia.org/r/681438

gerritbot added a comment.Apr 21 2021, 6:11 PM

Change 681616 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Skip OpenSearchLabelsTest::testOpenSearch

https://gerrit.wikimedia.org/r/681616

gerritbot added a comment.Apr 21 2021, 6:11 PM

Change 681451 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo EntityLinkFormatterFactory to service container

https://gerrit.wikimedia.org/r/681451

gerritbot added a comment.Apr 21 2021, 7:15 PM

Change 681455 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::getEntityLinkFormatterFactory() to static

https://gerrit.wikimedia.org/r/681455

gerritbot added a comment.Apr 21 2021, 10:36 PM

Change 681454 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityLinkFormatterFactory() to static

https://gerrit.wikimedia.org/r/681454

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 21 2021, 10:47 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
gerritbot added a comment.May 13 2024, 11:22 PM

Change #1031093 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Switch to a slightly less magic way of denoting how address should be updated

https://gerrit.wikimedia.org/r/1031093

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptMay 13 2024, 11:22 PM
gerritbot added a comment.May 14 2024, 12:44 AM

Change #1031107 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Finally push the recurring donation to the donation queue

https://gerrit.wikimedia.org/r/1031107

gerritbot added a comment.May 14 2024, 12:44 AM

Change #1031108 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Move the main message import to the DonationQueue handler

https://gerrit.wikimedia.org/r/1031108

gerritbot added a comment.May 14 2024, 6:18 PM

Change #1031093 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Switch to a slightly less magic way of denoting how address should be updated

https://gerrit.wikimedia.org/r/1031093

gerritbot added a comment.May 14 2024, 6:18 PM

Change #1031107 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Finally push the recurring donation to the donation queue

https://gerrit.wikimedia.org/r/1031107

gerritbot added a comment.May 14 2024, 6:18 PM

Change #1031108 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Move the main message import to the DonationQueue handler

https://gerrit.wikimedia.org/r/1031108

gerritbot added a comment.May 15 2024, 9:10 PM

Change #1031107 abandoned by Eileen:

[wikimedia/fundraising/crm@master] Finally push the recurring donation to the donation queue

Reason:

https://gerrit.wikimedia.org/r/1031107

gerritbot added a comment.May 15 2024, 9:10 PM

Change #1031108 abandoned by Eileen:

[wikimedia/fundraising/crm@master] Move the main message import to the DonationQueue handler

Reason:

https://gerrit.wikimedia.org/r/1031108

gerritbot added a comment.May 15 2024, 9:10 PM

Change #1031093 abandoned by Eileen:

[wikimedia/fundraising/crm@master] Switch to a slightly less magic way of denoting how address should be updated

Reason:

https://gerrit.wikimedia.org/r/1031093

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits