Page MenuHomePhabricator
Create Task
Maniphest T268600

Implement services through MediaWikiServices
Closed, ResolvedPublic
Actions

Description

Along the lines of ADR#15 and T265984, convert the services described in the current "top level factories" WikibaseRepo and WikibaseClient into service wiring.

As a result, a lot of boilerplate code can be avoided and - through extension.json - dependencies can be cleanly injected into MediaWiki pages (e.g.) without reaching into global scope.

A/C:

  • WikibaseRepo and WikibaseClient no longer have instances (getDefaultInstance() gone, constructor empty+private), all service getters are static wrappers around a ContainerInterface (like current WikibaseRepo::getEntityIdParser())
  • Test infrastructure that was custom built to reset changes to these services between tests is removed
    • i.e. remove WikibaseRepo::resetClassStatics() and WikibaseClient::getDefaultInstance( 'reset' )

Process to choose services to migrate
Start with the more core services to try and eliminate the dependency issues:

Bootstrapping WikibaseClient: start with the newInstance() dependencies – DataTypeDefinitions, EntityTypeDefinitions, EntitySourceDenifitions – then continue with more services.

Engineer picks up a service and:

  • Creates a ticket, does the migration and commits all the changes to the ticket

Once done with the migration of one service, the next service to migrate will be given by the migration that we have just migrated e.g. the one that depends on the one we just migrated and makes tickets for all the next available services to migrate. In absence of this go to any other service in the other repository.

Process to migrate one service (example: T272166)

  • Move the service initialization code to the service wiring file (repo/WikibaseRepo.ServiceWiring.php or client/WikibaseClient.ServiceWiring.php)
  • Make the WikibaseRepo/WikibaseClient method static and load the service from the container
  • Update callers of the WikibaseRepo/WikibaseClient method to either call the method statically or to properly inject the service where possible
  • Including callers in other extensions: use code search
  • Add unit test for service wiring

This is the list of services that will be migrated:

  • repo/includes/WikibaseRepo.php

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Addshore removed projects: Wikidata-Campsite, User-Pablo-WMDE.Jan 26 2021, 11:56 AM

Moving to be picked up as a hike via a bonfire

darthmon_wmde added a project: Wikibase Service Migration.Feb 12 2021, 11:04 AM
Lucas_Werkmeister_WMDE mentioned this in Wikibase Service Migration.Feb 22 2021, 10:34 AM
darthmon_wmde added a project: Epic.Feb 22 2021, 12:04 PM
darthmon_wmde updated the task description. (Show Details)
darthmon_wmde mentioned this in T275384: After migration, check broadly-used services that may have been affected.Feb 22 2021, 1:19 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 22 2021, 3:32 PM
ItamarWMDE updated the task description. (Show Details)Feb 23 2021, 1:54 PM
ItamarWMDE updated the task description. (Show Details)Feb 23 2021, 3:59 PM
ItamarWMDE updated the task description. (Show Details)Feb 23 2021, 6:00 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 23 2021, 6:05 PM
Lucas_Werkmeister_WMDE closed subtask T272166: Move StatementGuidParser from WikibaseRepo to service container as Resolved.Feb 24 2021, 12:22 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 25 2021, 11:35 AM
Lucas_Werkmeister_WMDE closed subtask T275399: Move StatementGuidValidator to service container in WikibaseRepo as Resolved.Feb 25 2021, 4:24 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 1 2021, 11:14 AM
ItamarWMDE updated the task description. (Show Details)Mar 2 2021, 9:23 AM
darthmon_wmde updated the task description. (Show Details)Mar 2 2021, 12:09 PM
darthmon_wmde updated the task description. (Show Details)Mar 2 2021, 12:11 PM
darthmon_wmde updated the task description. (Show Details)Mar 2 2021, 12:16 PM
darthmon_wmde updated the task description. (Show Details)Mar 2 2021, 12:21 PM
darthmon_wmde updated the task description. (Show Details)
ItamarWMDE updated the task description. (Show Details)Mar 4 2021, 9:46 AM
Rosalie_WMDE updated the task description. (Show Details)Mar 5 2021, 10:22 AM
Rosalie_WMDE updated the task description. (Show Details)Mar 5 2021, 10:30 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 5 2021, 12:18 PM
ItamarWMDE updated the task description. (Show Details)Mar 5 2021, 3:09 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 5 2021, 3:14 PM
ItamarWMDE updated the task description. (Show Details)Mar 9 2021, 4:17 PM
ItamarWMDE updated the task description. (Show Details)Mar 9 2021, 4:21 PM
ItamarWMDE updated the task description. (Show Details)Mar 11 2021, 5:12 PM
ItamarWMDE updated the task description. (Show Details)Mar 12 2021, 2:29 PM
Rosalie_WMDE updated the task description. (Show Details)Mar 16 2021, 1:37 PM
Rosalie_WMDE updated the task description. (Show Details)Mar 16 2021, 3:39 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 16 2021, 4:27 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Addshore moved this task from legacy-backlog to Active on the [DEPRECATED] wdwb-tech board.Mar 18 2021, 12:39 PM
Addshore edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (legacy-backlog).
ItamarWMDE updated the task description. (Show Details)Mar 18 2021, 4:15 PM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE updated the task description. (Show Details)Mar 19 2021, 6:00 PM
Rosalie_WMDE updated the task description. (Show Details)Mar 22 2021, 10:11 AM
Rosalie_WMDE updated the task description. (Show Details)
ItamarWMDE updated the task description. (Show Details)Mar 30 2021, 12:52 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 31 2021, 4:13 PM
ItamarWMDE updated the task description. (Show Details)Apr 6 2021, 4:08 PM
ItamarWMDE updated the task description. (Show Details)Apr 7 2021, 9:42 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 8 2021, 9:27 AM
Lucas_Werkmeister_WMDE mentioned this in T276581: Move WikibaseRepo SummaryFormatter to service container.Apr 8 2021, 3:27 PM
ItamarWMDE updated the task description. (Show Details)Apr 12 2021, 11:42 AM
ItamarWMDE updated the task description. (Show Details)Apr 14 2021, 11:07 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 15 2021, 4:23 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 16 2021, 4:05 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 16 2021, 4:08 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 20 2021, 12:04 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 21 2021, 3:49 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 21 2021, 10:50 PM
darthmon_wmde moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Apr 22 2021, 10:13 AM
ItamarWMDE updated the task description. (Show Details)Apr 22 2021, 4:44 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 30 2021, 2:45 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 30 2021, 3:58 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.May 3 2021, 9:32 AM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Done on the Wikibase Service Migration board.

I think this is actually completely done now 🎉🎊

ItamarWMDE mentioned this in T329828: [ES-M5] [EPIC] Migrate EntitySchema to use the MediaWiki Service Container .Feb 16 2023, 11:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits