Page MenuHomePhabricator
Create Task
Maniphest T276431

Move WikibaseClient StringNormalizer to service container
Closed, ResolvedPublic
Actions

Description

It’s buried somewhere in the entity source services / generic services, but actually it’s a trivial service that can probably be moved to the service container without trouble.

See also T276430.

Details

SubjectRepoBranchLines +/-
Make WikibaseClient::getStringNormalizer() staticmediawiki/extensions/Wikibasemaster+1 -1
client: Move StringNormalizer to service containermediawiki/extensions/Wikibasemaster+32 -8
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 4 2021, 10:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2021, 10:03 AM
Lucas_Werkmeister_WMDE mentioned this in T276430: Move WikibaseRepo StringNormalizer to service container.Mar 4 2021, 10:03 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T276458: Move WikibaseClient LanguageFallbackChainFactory to service container.Mar 4 2021, 2:16 PM
Rosalie_WMDE claimed this task.Mar 5 2021, 8:15 AM
Rosalie_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T276531: Remove StringNormalizer from WikibaseServices.Mar 5 2021, 10:32 AM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 5 2021, 12:18 PM
gerritbot added a comment.Mar 9 2021, 8:11 AM

Change 670093 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] client: Move StringNormalizer to service container

https://gerrit.wikimedia.org/r/670093

gerritbot added a project: Patch-For-Review.Mar 9 2021, 8:11 AM
Rosalie_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 9 2021, 9:04 AM
gerritbot added a comment.Mar 9 2021, 10:27 AM

Change 670093 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] client: Move StringNormalizer to service container

https://gerrit.wikimedia.org/r/670093

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 9 2021, 10:28 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 9 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 9 2021, 11:10 AM
gerritbot added a comment.Apr 9 2021, 3:34 PM

Change 678272 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Make WikibaseClient::getStringNormalizer() static

https://gerrit.wikimedia.org/r/678272

gerritbot added a project: Patch-For-Review.Apr 9 2021, 3:34 PM
gerritbot added a comment.Apr 12 2021, 1:53 AM

Change 678272 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make WikibaseClient::getStringNormalizer() static

https://gerrit.wikimedia.org/r/678272

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 12 2021, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 12 2021, 2:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL