Page MenuHomePhabricator
Create Task
Maniphest T279528

Move WikibaseRepo PropertyLookup to service container
Closed, ResolvedPublic
Actions

Description

Can be done after T278926: Move WikibaseRepo EntityLookup to service container, and will need similar backwards compatibility for the $cacheMode argument as in that task, I assume.

Details

SubjectRepoBranchLines +/-
repo: remove getPropertyLookup() from WikibaseRepomediawiki/extensions/Wikibasemaster+13 -10
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 7 2021, 11:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2021, 11:50 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Apr 7 2021, 11:50 AM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Apr 7 2021, 4:26 PM

See also discussion at T279527: Move WikibaseRepo ItemLookup to service container.

Lucas_Werkmeister_WMDE claimed this task.Apr 7 2021, 4:37 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 7 2021, 4:55 PM
gerritbot added a comment.Apr 7 2021, 4:55 PM

Change 677615 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: remove getPropertyLookup() from WikibaseRepo

https://gerrit.wikimedia.org/r/677615

gerritbot added a project: Patch-For-Review.Apr 7 2021, 4:55 PM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 8 2021, 9:27 AM
gerritbot added a comment.Apr 9 2021, 11:52 AM

Change 677615 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: remove getPropertyLookup() from WikibaseRepo

https://gerrit.wikimedia.org/r/677615

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 9 2021, 11:55 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 9 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2021, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits