Page MenuHomePhabricator

Move WikibaseRepo EntityLookup to service container
Closed, ResolvedPublic

Description

WikibaseRepo::getEntityLookup() has optional $cache and $lookupMode arguments, which we can’t directly include in the migration, but we can use the default modes for the lookup in the service container, use that for all callers that use the default lookup, and migrate the others to call $store->getEntityLookup( $cache, $lookupMode ) directly instead.

Event Timeline

Change 677542 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: move EntityLookup to service container

https://gerrit.wikimedia.org/r/677542

Change 677543 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677543

Change 677544 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677544

Change 677545 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677545

Change 677546 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/MachineVision@master] Update WikibaseRepo::getEntityLookup() call

https://gerrit.wikimedia.org/r/677546

Change 677547 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Update WikibaseRepo::getEntityLookup() call

https://gerrit.wikimedia.org/r/677547

Change 677548 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677548

Change 677550 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677550

Change 677585 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Hard-deprecate WikibaseRepo::getEntityLookup() with arguments

https://gerrit.wikimedia.org/r/677585

Change 677542 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: move EntityLookup to service container

https://gerrit.wikimedia.org/r/677542

Change 677543 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677543

Change 677547 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Update WikibaseRepo::getEntityLookup() call

https://gerrit.wikimedia.org/r/677547

Change 677546 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] Update WikibaseRepo::getEntityLookup() call

https://gerrit.wikimedia.org/r/677546

Change 677548 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677548

Change 677550 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677550

Change 677545 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677545

Change 677544 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677544

Change 677585 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Hard-deprecate WikibaseRepo::getEntityLookup() with arguments

https://gerrit.wikimedia.org/r/677585

reopening because i’m stupid

Change 677603 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix MediaWiki version in deprecation message

https://gerrit.wikimedia.org/r/677603

Change 677603 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix MediaWiki version in deprecation message

https://gerrit.wikimedia.org/r/677603

Change 678219 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_36] Fix MediaWiki version in deprecation warning again

https://gerrit.wikimedia.org/r/678219

Change 678249 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: inject EntityLookup directly

https://gerrit.wikimedia.org/r/678249

Change 678250 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/PropertySuggester@master] Get EntityLookup directly from WikibaseRepo

https://gerrit.wikimedia.org/r/678250

Change 678350 had a related patch set uploaded (by Jforrester; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix MediaWiki version in deprecation warning again

https://gerrit.wikimedia.org/r/678350

Change 678350 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix MediaWiki version in deprecation warning again

https://gerrit.wikimedia.org/r/678350

Change 678219 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_36] Fix MediaWiki version in deprecation warning again

https://gerrit.wikimedia.org/r/678219

Change 678249 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: inject EntityLookup directly

https://gerrit.wikimedia.org/r/678249