Page MenuHomePhabricator
Create Task
Maniphest T278926

Move WikibaseRepo EntityLookup to service container
Closed, ResolvedPublic
Actions

Description

WikibaseRepo::getEntityLookup() has optional $cache and $lookupMode arguments, which we can’t directly include in the migration, but we can use the default modes for the lookup in the service container, use that for all callers that use the default lookup, and migrate the others to call $store->getEntityLookup( $cache, $lookupMode ) directly instead.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 31 2021, 9:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2021, 9:53 AM
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Service Migration.Mar 31 2021, 9:53 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 31 2021, 4:13 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 7 2021, 10:05 AM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 7 2021, 11:44 AM

Change 677542 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: move EntityLookup to service container

https://gerrit.wikimedia.org/r/677542

gerritbot added a project: Patch-For-Review.Apr 7 2021, 11:44 AM

Change 677543 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677543

gerritbot added a comment.Apr 7 2021, 11:45 AM

Change 677544 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677544

gerritbot added a comment.Apr 7 2021, 11:45 AM

Change 677545 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677545

gerritbot added a comment.Apr 7 2021, 11:45 AM

Change 677546 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/MachineVision@master] Update WikibaseRepo::getEntityLookup() call

https://gerrit.wikimedia.org/r/677546

gerritbot added a comment.Apr 7 2021, 11:45 AM

Change 677547 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Update WikibaseRepo::getEntityLookup() call

https://gerrit.wikimedia.org/r/677547

gerritbot added a comment.Apr 7 2021, 11:45 AM

Change 677548 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677548

gerritbot added a comment.Apr 7 2021, 11:45 AM

Change 677550 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677550

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 7 2021, 11:46 AM
Lucas_Werkmeister_WMDE mentioned this in T279526: Move WikibaseRepo PropertyDataTypeLookup to service container.Apr 7 2021, 11:48 AM
Lucas_Werkmeister_WMDE mentioned this in T279527: Move WikibaseRepo ItemLookup to service container.
Lucas_Werkmeister_WMDE mentioned this in T279528: Move WikibaseRepo PropertyLookup to service container.
Lucas_Werkmeister_WMDE mentioned this in T279529: Move WikibaseRepo DefaultValidatorBuilders to service container.Apr 7 2021, 11:53 AM
gerritbot added a comment.Apr 7 2021, 2:21 PM

Change 677585 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Hard-deprecate WikibaseRepo::getEntityLookup() with arguments

https://gerrit.wikimedia.org/r/677585

gerritbot added a comment.Apr 7 2021, 3:27 PM

Change 677542 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: move EntityLookup to service container

https://gerrit.wikimedia.org/r/677542

gerritbot added a comment.Apr 7 2021, 3:27 PM

Change 677543 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677543

gerritbot added a comment.Apr 7 2021, 3:33 PM

Change 677547 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Update WikibaseRepo::getEntityLookup() call

https://gerrit.wikimedia.org/r/677547

gerritbot added a comment.Apr 7 2021, 3:33 PM

Change 677546 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] Update WikibaseRepo::getEntityLookup() call

https://gerrit.wikimedia.org/r/677546

gerritbot added a comment.Apr 7 2021, 3:34 PM

Change 677548 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677548

gerritbot added a comment.Apr 7 2021, 3:34 PM

Change 677550 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677550

gerritbot added a comment.Apr 7 2021, 3:34 PM

Change 677545 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677545

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 7 2021, 4:00 PM
gerritbot added a comment.Apr 7 2021, 4:02 PM

Change 677544 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityLookup() calls

https://gerrit.wikimedia.org/r/677544

gerritbot added a comment.Apr 7 2021, 4:07 PM

Change 677585 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Hard-deprecate WikibaseRepo::getEntityLookup() with arguments

https://gerrit.wikimedia.org/r/677585

Lucas_Werkmeister_WMDE mentioned this in rEWLCf222aa61e564: Update WikibaseRepo::getEntityLookup() calls.Apr 7 2021, 4:08 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 7 2021, 4:15 PM
Lucas_Werkmeister_WMDE mentioned this in T279563: Remove backwards compatibility code from WikibaseRepo::getEntityLookup().
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

I think we can close this – I created a separate task for the final cleanup, T279563: Remove backwards compatibility code from WikibaseRepo::getEntityLookup().

Lucas_Werkmeister_WMDE reopened this task as Open.Apr 7 2021, 4:19 PM
Lucas_Werkmeister_WMDE moved this task from Done to Up for review on the Wikibase Service Migration board.

reopening because i’m stupid

gerritbot added a comment.Apr 7 2021, 4:19 PM

Change 677603 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix MediaWiki version in deprecation message

https://gerrit.wikimedia.org/r/677603

Lucas_Werkmeister_WMDE mentioned this in T278345: 1.37.0-wmf.1 deployment blockers.Apr 7 2021, 4:22 PM
gerritbot added a comment.Apr 8 2021, 4:16 PM

Change 677603 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix MediaWiki version in deprecation message

https://gerrit.wikimedia.org/r/677603

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 8 2021, 4:34 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
gerritbot added a comment.Apr 9 2021, 9:31 AM

Change 678219 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_36] Fix MediaWiki version in deprecation warning again

https://gerrit.wikimedia.org/r/678219

gerritbot added a comment.Apr 9 2021, 1:37 PM

Change 678249 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: inject EntityLookup directly

https://gerrit.wikimedia.org/r/678249

gerritbot added a comment.Apr 9 2021, 1:37 PM

Change 678250 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/PropertySuggester@master] Get EntityLookup directly from WikibaseRepo

https://gerrit.wikimedia.org/r/678250

gerritbot added a comment.Apr 10 2021, 9:30 PM

Change 678350 had a related patch set uploaded (by Jforrester; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix MediaWiki version in deprecation warning again

https://gerrit.wikimedia.org/r/678350

gerritbot added a comment.Apr 10 2021, 9:57 PM

Change 678350 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix MediaWiki version in deprecation warning again

https://gerrit.wikimedia.org/r/678350

gerritbot added a comment.Apr 10 2021, 10:19 PM

Change 678219 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_36] Fix MediaWiki version in deprecation warning again

https://gerrit.wikimedia.org/r/678219

gerritbot added a comment.Apr 12 2021, 1:53 AM

Change 678249 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: inject EntityLookup directly

https://gerrit.wikimedia.org/r/678249

gerritbot added a comment.May 10 2021, 9:43 AM

Change 678250 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Get EntityLookup directly from WikibaseRepo

https://gerrit.wikimedia.org/r/678250

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.5; 2021-05-11); removed MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).May 10 2021, 10:00 AM
Lucas_Werkmeister_WMDE mentioned this in rEPS277ff02acca4: Get EntityLookup directly from WikibaseRepo.May 10 2021, 10:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits