Can be done after T278926: Move WikibaseRepo EntityLookup to service container.
This also uses getCachingCommonsMediaFileNameLookup(), which isn’t called anywhere else (and is private), so maybe that can be inlined. Or moved as a service to the service container, of course.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| repo: move DefaultValidatorBuilders to service container | mediawiki/extensions/Wikibase | master | +77 -54 |
Hm, on second thought, this is all early bootstrap code. Not sure if we want to touch that yet, to be honest.
Correction: it’s bootstrap code, but it doesn’t seem to be early – it seems to be called only fairly late into an edit request (and not at all on ordinary get requests, at least as far as I’ve tried), when the time comes to validate an edit. The service container should be well available by that time.
Change 679342 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: move DefaultValidatorBuilders to service container
This also uses getCachingCommonsMediaFileNameLookup(), which isn’t called anywhere else (and is private), so maybe that can be inlined. Or moved as a service to the service container, of course.
(This was since moved to the service container in T279918.)
Change 679342 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: move DefaultValidatorBuilders to service container