Remove backwards compatibility code from WikibaseRepo::getEntityLookup()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Lucas_Werkmeister_WMDE
	Apr 7 2021, 4:15 PM

Description

In T278926, we hard-deprecated calling WikibaseRepo::getEntityLookup() with $cache and $lookupMode arguments. After verifying that no deprecation warnings show up in production, we should remove that backwards compatibility code entirely.

Details

	Subject	Repo	Branch	Lines +/-
	Remove backwards compatibility code from getEntityLookup()	mediawiki/extensions/Wikibase	REL1_36	+3 -92
	Remove backwards compatibility code from getEntityLookup()	mediawiki/extensions/Wikibase	master	+3 -90

Customize query in gerrit

Related Objects

Mentioned In: T279653: Remove backwards compatibility code from WikibaseRepo::getEntityRevisionLookup()
T278926: Move WikibaseRepo EntityLookup to service container
Mentioned Here: T278926: Move WikibaseRepo EntityLookup to service container

Event Timeline

• Lucas_Werkmeister_WMDE created this task.Apr 7 2021, 4:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2021, 4:15 PM

• Lucas_Werkmeister_WMDE mentioned this in T278926: Move WikibaseRepo EntityLookup to service container.Apr 7 2021, 4:15 PM

• Lucas_Werkmeister_WMDE mentioned this in T279653: Remove backwards compatibility code from WikibaseRepo::getEntityRevisionLookup().Apr 8 2021, 11:55 AM

We probably want to backport that removal to the REL1_36 branch too.

No deprecation notices found in logstash; let’s do this.

• Lucas_Werkmeister_WMDE claimed this task.Apr 20 2021, 2:06 PM

• Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Change 681401 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove backwards compatibility code from getEntityLookup()

https://gerrit.wikimedia.org/r/681401

gerritbot added a project: Patch-For-Review.Apr 20 2021, 2:09 PM

• Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 20 2021, 2:09 PM

Change 681401 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove backwards compatibility code from getEntityLookup()

https://gerrit.wikimedia.org/r/681401

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 9:00 AM

Moving back for the backport.

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 9:11 AM

• Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.Apr 21 2021, 9:11 AM

Change 681382 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_36] Remove backwards compatibility code from getEntityLookup()

https://gerrit.wikimedia.org/r/681382

gerritbot added a project: Patch-For-Review.Apr 21 2021, 9:12 AM

• Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 21 2021, 9:15 AM

Change 681382 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_36] Remove backwards compatibility code from getEntityLookup()

https://gerrit.wikimedia.org/r/681382

• Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 22 2021, 8:00 AM

• Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

Maintenance_bot removed a project: Patch-For-Review.Apr 22 2021, 8:10 AM

Remove backwards compatibility code from WikibaseRepo::getEntityLookup()Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Remove backwards compatibility code from WikibaseRepo::getEntityLookup()
Closed, ResolvedPublic
Actions