Page MenuHomePhabricator
Create Task
Maniphest T279653

Remove backwards compatibility code from WikibaseRepo::getEntityRevisionLookup()
Closed, ResolvedPublic
Actions

Description

Similar to T279563: In T278925, we hard-deprecated calling WikibaseRepo::getEntityRevisionLookup() with a $cache argument. After verifying that no deprecation warnings show up in production, we should remove that backwards compatibility code entirely.

Details

SubjectRepoBranchLines +/-
Remove backwards compatibility code from getEntityRevisionLookup()mediawiki/extensions/Wikibasemaster+3 -61
Remove backwards compatibility code from getEntityRevisionLookup()mediawiki/extensions/WikibaseREL1_36+15 -1
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 8 2021, 11:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2021, 11:55 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 20 2021, 12:00 PM

No deprecation notices found in logstash; let’s do this.

Lucas_Werkmeister_WMDE claimed this task.Apr 20 2021, 2:10 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 20 2021, 2:11 PM

Change 681402 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove backwards compatibility code from getEntityRevisionLookup()

https://gerrit.wikimedia.org/r/681402

gerritbot added a project: Patch-For-Review.Apr 20 2021, 2:11 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 20 2021, 2:12 PM
gerritbot added a comment.Apr 21 2021, 11:00 AM

Change 681402 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove backwards compatibility code from getEntityRevisionLookup()

https://gerrit.wikimedia.org/r/681402

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 11:11 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Doing on the Wikibase Service Migration board.Apr 21 2021, 11:12 AM
gerritbot added a comment.Apr 21 2021, 11:13 AM

Change 681627 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_36] Remove backwards compatibility code from getEntityRevisionLookup()

https://gerrit.wikimedia.org/r/681627

gerritbot added a project: Patch-For-Review.Apr 21 2021, 11:13 AM
gerritbot added a comment.Apr 21 2021, 11:16 AM

Change 681627 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@REL1_36] Remove backwards compatibility code from getEntityRevisionLookup()

Reason:

The getEntityRevisionLookup() migration happened after the REL1_36 branch cut so the removal doesn’t need to be backported

https://gerrit.wikimedia.org/r/681627

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 21 2021, 11:17 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits