1.37.0-wmf.1 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor: dduvall
Release Version: 1.37.0-wmf.1
Release Date: Apr 12 2021, 12:00 AM

2021 week 15 1.37-wmf.1 Changes wmf/1.37.0-wmf.1

This MediaWiki Train Deployment is scheduled for the week of Monday, April 12th:

Monday April 12th	Tuesday, April 13th	Wednesday, April 14th	Thursday, April 15th	Friday
Backports only.	Branch `wmf.1` and deploy to Group 0 Wikis.	Deploy `wmf.1` to Group 1 Wikis.	Deploy `wmf.1` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.1 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.36.0-wmf.38

Next: 1.37.0-wmf.2

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	jeena	T278345 1.37.0-wmf.1 deployment blockers
Resolved		Jdlrobson	T279008 mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content
Resolved	PRODUCTION ERROR	AnneT	T279113 Unable to parse title at new Title in Special:MediaSearch
Resolved	PRODUCTION ERROR	matmarex	T280082 Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'mediawikiwiki.discussiontools_subscription' doesn't exist (10.64.16.7)

Event Timeline

thcipriani created this task.Mar 24 2021, 3:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2021, 3:46 PM

thcipriani assigned this task to jeena.Mar 26 2021, 6:05 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: dduvall.

thcipriani added a project: Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)) board.

Jdlrobson added a subtask: T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.Apr 5 2021, 5:39 PM

Jdlrobson closed subtask T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content as Resolved.Apr 6 2021, 6:36 PM

thcipriani changed Release Version from 1.36.0-wmf.39 to 1.37.0-wmf.1.Apr 6 2021, 7:50 PM

jeena renamed this task from 1.36.0-wmf.39 deployment blockers to 1.37.0-wmf.1 deployment blockers.Apr 6 2021, 7:52 PM

Nonrisky change: we added a hard deprecation to Wikibase in T278926. If you see this message:

Use of Wikibase\Repo\WikibaseRepo::getEntityLookup with non-default $cache or $lookupMode was deprecated in WikibaseRepo 1.37.

It’s fine, the code should still work, there’s no need to block the train (unless you want to, e.g. because it’s excessive logspam), but feel free to let us know at Wikibase Service Migration.

WMDE-leszek subscribed.Apr 7 2021, 5:06 PM

dduvall added a subtask: T279113: Unable to parse title at new Title in Special:MediaSearch.Apr 7 2021, 11:06 PM

Etonkovidova closed subtask T279113: Unable to parse title at new Title in Special:MediaSearch as Resolved.Apr 9 2021, 12:19 AM

In T278345#6980879, @Lucas_Werkmeister_WMDE wrote:

Nonrisky change: we added a hard deprecation to Wikibase in T278926. If you see this message:

Use of Wikibase\Repo\WikibaseRepo::getEntityLookup with non-default $cache or $lookupMode was deprecated in WikibaseRepo 1.37.

It’s fine, the code should still work, there’s no need to block the train (unless you want to, e.g. because it’s excessive logspam), but feel free to let us know at Wikibase Service Migration.

The same goes for getEntityRevisionLookup (T278925), i.e. this message is also harmless:

Use of Wikibase\Repo\WikibaseRepo::getEntityRevisionLookup with non-default $cache was deprecated in WikibaseRepo 1.37.

RhinosF1 subscribed.Apr 12 2021, 5:04 PM

matmarex edited subtasks, added: T279604: [Regression pre-wmf.38] Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster; removed: T279949: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean.Apr 12 2021, 9:08 PM

Hello, is this going to be wmf.1 deployment, or wmf.39 deployment? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/678677 seems to create wmf.39, but this task disagrees.

Ladsgroup subscribed.Apr 13 2021, 10:26 AM

In T278345#6993194, @Urbanecm wrote:

Hello, is this going to be wmf.1 deployment, or wmf.39 deployment? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/678677 seems to create wmf.39, but this task disagrees.

Sigh. The only variable in our branch job that has to change in our automated branch cut job is MAJOR_VERSION. Forgot to change it when we updated this task. Re-running the job now.

Urbanecm removed a subtask: T279604: [Regression pre-wmf.38] Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster.Apr 13 2021, 8:56 PM

Urbanecm added a subtask: T280082: Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'mediawikiwiki.discussiontools_subscription' doesn't exist (10.64.16.7).Apr 13 2021, 9:31 PM

Urbanecm closed subtask T280082: Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'mediawikiwiki.discussiontools_subscription' doesn't exist (10.64.16.7) as Resolved.Apr 14 2021, 9:25 AM

Change 679421 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.1 refs T278345

https://gerrit.wikimedia.org/r/679421

Change 679421 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.1 refs T278345

https://gerrit.wikimedia.org/r/679421

Mentioned in SAL (#wikimedia-operations) [2021-04-14T19:04:41Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.37.0-wmf.1 refs T278345

Mentioned in SAL (#wikimedia-operations) [2021-04-14T19:06:45Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.37.0-wmf.1 refs T278345 (duration: 02m 03s)

We have noticed a rendering change on English Wiktionary after this deployment. The first report was 22:44 UTC yesterday, a few hours after the deployment.

Pages with wikitext such as # {{senseid|en|something}} Definition, such as https://en.wiktionary.org/wiki/-ar, now display an extra blank list item which was not previously shown.

Compare http://web.archive.org/web/20210411024459/http://en.wiktionary.org/wiki/fall (11 April) with https://en.wiktionary.org/w/index.php?title=fall&oldid=62242836 - there is an extra list item at 3.2

It seems that content.parser-output.less is no longer being included in the minified CSS. @Jdlrobson @Ammarpad @matmarex

@TTO thanks for the report. I have opened a ticket: T280260

Change 679925 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] all wikis to 1.37.0-wmf.1 refs T278345

https://gerrit.wikimedia.org/r/679925

Change 679925 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.37.0-wmf.1 refs T278345

https://gerrit.wikimedia.org/r/679925

Mentioned in SAL (#wikimedia-operations) [2021-04-15T19:14:16Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.37.0-wmf.1 refs T278345

matmarex unsubscribed.Apr 15 2021, 8:09 PM

Jdforrester-WMF closed this task as Resolved.Apr 15 2021, 10:51 PM

matmarex mentioned this in T261992: Uncaught TypeError: Cannot read property 'offsetHeight' of null.May 25 2021, 7:00 PM

1.37.0-wmf.1 deployment blockersClosed, ResolvedPublicReleaseActions