Page MenuHomePhabricator
Create Task
Maniphest T277489

Move WikibaseRepo LocalRepoWikipageMetaDataAccessor to service container
Closed, ResolvedPublic
Actions

Description

Can be done after T277313: Move WikibaseRepo EntityNamespaceLookup to service container.

Details

SubjectRepoBranchLines +/-
Update WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor() callsmediawiki/extensions/WikibaseLexememaster+2 -2
Make WikiPageEntityMetaDataLookup default to NullLoggermediawiki/extensions/Wikibasemaster+2 -2
Update WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor() callmediawiki/extensions/WikibaseQualityConstraintsmaster+2 -3
Inject logger into WikiPageEntityMetaDataLookupmediawiki/extensions/WikibaseMediaInfomaster+2 -1
repo: move LocalRepoWikiPageMetaDataAccessor to service containermediawiki/extensions/Wikibasemaster+84 -37
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 15 2021, 5:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2021, 5:07 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Mar 15 2021, 5:12 PM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 16 2021, 4:27 PM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Mar 17 2021, 10:16 AM
Lucas_Werkmeister_WMDE added a comment.Mar 30 2021, 3:04 PM

Side note: this service is not used in Wikibase itself, only in WikibaseQualityConstraints and WikibaseLexeme. As far as I can tell from the Git history, that’s always been this way, and it’s apparently intentional (T206164).

Lucas_Werkmeister_WMDE claimed this task.Mar 30 2021, 4:10 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Mar 30 2021, 4:50 PM

Change 675836 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: move LocalRepoWikiPageMetaDataAccessor to service container

https://gerrit.wikimedia.org/r/675836

gerritbot added a project: Patch-For-Review.Mar 30 2021, 4:50 PM

Change 675837 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor() calls

https://gerrit.wikimedia.org/r/675837

gerritbot added a comment.Mar 30 2021, 4:51 PM

Change 675838 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor() call

https://gerrit.wikimedia.org/r/675838

gerritbot added a comment.Mar 30 2021, 4:51 PM

Change 675839 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Inject logger into WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/675839

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 30 2021, 4:51 PM
gerritbot added a comment.Mar 30 2021, 5:03 PM

Change 675840 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Make WikiPageEntityMetaDataLookup default to NullLogger

https://gerrit.wikimedia.org/r/675840

gerritbot added a comment.Mar 31 2021, 9:34 AM

Change 675836 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: move LocalRepoWikiPageMetaDataAccessor to service container

https://gerrit.wikimedia.org/r/675836

gerritbot added a comment.Mar 31 2021, 9:34 AM

Change 675838 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor() call

https://gerrit.wikimedia.org/r/675838

gerritbot added a comment.Mar 31 2021, 9:34 AM

Change 675839 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Inject logger into WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/675839

gerritbot added a comment.Mar 31 2021, 9:34 AM

Change 675837 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getLocalRepoWikiPageMetaDataAccessor() calls

https://gerrit.wikimedia.org/r/675837

gerritbot added a comment.Mar 31 2021, 9:55 AM

Change 675840 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make WikiPageEntityMetaDataLookup default to NullLogger

https://gerrit.wikimedia.org/r/675840

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Mar 31 2021, 10:00 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 31 2021, 10:00 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Maintenance_bot removed a project: Patch-For-Review.Mar 31 2021, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL