Page MenuHomePhabricator
Create Task
Maniphest T277533

Move WikibaseRepo InternalFormatStatementDeserializer to service container
Closed, ResolvedPublic
Actions

Description

Can be done after T277299: WikibaseRepo: Move InternalFormatDeserializerFactory to service container.

Details

SubjectRepoBranchLines +/-
Remove InternalFormatStatementDeserializer from WikibaseRepomediawiki/extensions/Wikibasemaster+0 -13
Move WikibaseRepo InternalFormatStatementDeserializer to service containermediawiki/extensions/Wikibasemaster+44 -8
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 16 2021, 12:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2021, 12:24 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Mar 16 2021, 12:24 PM
Lucas_Werkmeister_WMDE added a comment.Mar 16 2021, 12:34 PM

Apparently this method/service hasn’t actually been used since Ieee787509a T182137: Clean up backward compatibility of EntityDiffAspects in Wikibase? Probably best to just remove it, then.

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 16 2021, 4:27 PM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Mar 17 2021, 10:20 AM
ItamarWMDE claimed this task.Mar 29 2021, 9:56 AM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Mar 29 2021, 10:34 AM

Change 675488 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Move WikibaseRepo InternalFormatStatementDeserializer to service container

https://gerrit.wikimedia.org/r/675488

gerritbot added a project: Patch-For-Review.Mar 29 2021, 10:34 AM
ItamarWMDE added a comment.Mar 29 2021, 10:35 AM
In T277533#6917119, @Lucas_Werkmeister_WMDE wrote:

Apparently this method/service hasn’t actually been used since Ieee787509a T182137: Clean up backward compatibility of EntityDiffAspects in Wikibase? Probably best to just remove it, then.

Oh wow, somehow I missed this! yeah I was wondering the same thing but migrated it in the end. Will remove it now...

gerritbot added a comment.Mar 29 2021, 10:38 AM

Change 675488 abandoned by Itamar Givon:
[mediawiki/extensions/Wikibase@master] Move WikibaseRepo InternalFormatStatementDeserializer to service container

Reason:

https://gerrit.wikimedia.org/r/675488

gerritbot added a comment.Mar 29 2021, 10:41 AM

Change 675489 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Remove InternalFormatStatementDeserializer from WikibaseRepo

https://gerrit.wikimedia.org/r/675489

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 29 2021, 10:41 AM
gerritbot added a comment.Mar 29 2021, 11:11 AM

Change 675489 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove InternalFormatStatementDeserializer from WikibaseRepo

https://gerrit.wikimedia.org/r/675489

ItamarWMDE closed this task as Resolved.Mar 29 2021, 11:17 AM
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 29 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 29 2021, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits