Page MenuHomePhabricator
Create Task
Maniphest T280571

Remove ContentLanguage from WikibaseClient
Closed, ResolvedPublic
Actions

Description

WikibaseClient::getContentLanguage() is no longer used within the WikibaseClient class, only in one hook handler (which should get it injected instead) and in a test. Let’s get rid of it.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+4 -27Remove WikibaseClient::getContentLanguage()
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 19 2021, 5:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2021, 5:26 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 19 2021, 5:26 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 19 2021, 5:28 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 19 2021, 5:32 PM

Change 681140 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove WikibaseClient::getContentLanguage()

https://gerrit.wikimedia.org/r/681140

gerritbot added a project: Patch-For-Review.Apr 19 2021, 5:32 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 19 2021, 5:32 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Apr 20 2021, 7:26 AM
gerritbot added a comment.Apr 20 2021, 9:59 AM

Change 681140 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseClient::getContentLanguage()

https://gerrit.wikimedia.org/r/681140

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 20 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 20 2021, 10:10 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 20 2021, 11:09 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 20 2021, 12:04 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL