Move WikibaseClient PropertyLabelResolver to service container
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Mar 16 2021, 5:01 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Lucas_Werkmeister_WMDE

Description

Can be done after T277574: Move WikibaseClient PropertySource to service container. (I suggest inlining getCachedDatabasePropertyLabelResolver(), getLoadBalancerForConfiguredPropertySource() and getDatabaseDomainForPropertySource() – I don’t think those make sense as dedicated services.)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Move WikibaseClient PropertyLabelResolver to service container	Itamar Givon	mediawiki/extensions/Wikibase	master	+111 -94

Customize query in gerrit

Related Objects

Mentioned In: T268600: Implement services through MediaWikiServices
Mentioned Here: T277574: Move WikibaseClient PropertySource to service container

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 16 2021, 5:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2021, 5:01 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Mar 16 2021, 5:01 PM

Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Mar 29 2021, 2:20 PM

ItamarWMDE claimed this task.Mar 30 2021, 12:57 PM

ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Change 675810 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Move WikibaseClient PropertyLabelResolver to service container

https://gerrit.wikimedia.org/r/675810

gerritbot added a project: Patch-For-Review.Mar 30 2021, 2:30 PM

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 30 2021, 3:30 PM

Change 675810 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseClient PropertyLabelResolver to service container

https://gerrit.wikimedia.org/r/675810

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 31 2021, 9:39 AM

Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Mar 31 2021, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2021, 10:10 AM

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 31 2021, 4:13 PM