To break this technological barrier and make further migrations just a matter of effort, not adventurousness.
Original idea was: Inject a shared service (ObjectCache) into FormatterCacheFactory from MW service. Could only be done once there is a patch for T265983: Make shared caching service (ObjectCache) injectable into FormatterCacheFactory
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | WMDE-leszek | T252595 Consider ways to invalidate FormatterCache when things go wrong | |||
| Resolved | • Pablo-WMDE | T265984 Create first exemplary services in WikibaseRepo |
Had a chat with @Lucas_Werkmeister_WMDE, @Tarrow & @toan.
We found out that there is no (popular, at least) scenario in which both the wikibase repo and client code would run at the same time - as such, it is not of highest priority to prevent this part of the application from instantiating the service(s) redundantly (as it does not happen in practice).
However, we see the desire for a less verbose way of maintaining our service definitions, wiring & align it with the way MediaWiki does it to reduce the barrier to entry for future wikibase devs and non-team members.
Steps in mind
Change 636675 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] ADR: use PSR11 MediaWiki service container
Change 636675 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ADR: use PSR11 MediaWiki service container
With the ADR merged, let's look into how we can get the first services actually implemented this way (in the least invasive fashion).
Change 640182 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Move data+entity type definitions to service wiring
Since the above change doesn’t really expose the data + entity type definitions as services (they’re still stored as members of the WikibaseRepo instance), I wouldn’t consider this task done with only that change merged – we should also have some (simple) service that’s completely migrated to the service container (WikibaseRepo could still have a getter but it would get it from the MediaWikiServices). @Pablo-WMDE volunteered to attempt that, but in the meantime, let’s move this to Review for the first change.
Change 640825 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: turn DataTypeDefinitions into a used service
Change 640833 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: turn EntityTypeDefinitions into a used service
Change 640834 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: directly inject DataTypeDefinitions where possible
Change 640941 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: turn ValueParserFactory into service
Change 640949 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Update getDataTypeDefinitions() call
Change 640950 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseCirrusSearch@master] Update getDataTypeDefinitions() call
Change 640951 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update getDataTypeDefinitions() call
Change 640952 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: allow inherting EntityTypeDefinitions config
Change 640953 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeHandlerTest: extend wikibase EntityTypeDefinitions
Change 640957 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: turn DataTypeFactory into service
Change 640983 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseCirrusSearch@master] EntityHandlerTestCases: use inheritable EntityTypeDefinitions
Change 640997 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] LexemeHandlerTest: use inheritable EntityTypeDefinitions
Change 640998 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: private getEntityTypeDefinitions()
Change 640952 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: allow inherting EntityTypeDefinitions config
Change 640953 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LexemeHandlerTest: extend wikibase EntityTypeDefinitions
Change 640997 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] LexemeHandlerTest: use inheritable EntityTypeDefinitions
Change 640983 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] EntityHandlerTestCases: use inheritable EntityTypeDefinitions
Change 640998 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: final getEntityTypeDefinitions()
Change 641196 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] WikibaseRepoTest: refactor for clarity
Change 641389 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: add testing for ServiceWiring
Change 640182 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: move data+entity type definitions to service wiring
Change 640825 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: turn DataTypeDefinitions into a used service
Change 640834 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: directly inject DataTypeDefinitions where possible
Change 640941 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: turn ValueParserFactory into service
Change 640957 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: turn DataTypeFactory into service
Change 641196 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] WikibaseRepoTest: refactor for clarity
Change 640833 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: turn EntityTypeDefinitions into a used service
Change 641389 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: add testing for ServiceWiring
Change 641738 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: make PropertyValueExpertsModule a service
Change 641738 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: make PropertyValueExpertsModule a service
Change 641956 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Fix LexemeHandlerTest::getEntityTypeDefinitionsConfiguration()
Change 640949 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Update getDataTypeDefinitions() call
Change 640950 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Update getDataTypeDefinitions() call
Change 641956 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Fix LexemeHandlerTest::getEntityTypeDefinitionsConfiguration()
Change 640951 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update getDataTypeDefinitions() call