Maniphest T280573

Move WikibaseClient ReferenceFormatterFactory to service container
Closed, ResolvedPublic
Actions

Assigned To

Lucas_Werkmeister_WMDE

Authored By

	Lucas_Werkmeister_WMDE
	Apr 19 2021, 5:26 PM

Tags

Referenced Files

None

Subscribers

Lucas_Werkmeister_WMDE

Description

This still calls getDataAccessSnakFormatterFactory() non-statically, but in fact that service was already migrated in T279995: Move WikibaseClient DataAccessSnakFormatterFactory to service container.

Details

	Subject	Repo	Branch	Lines +/-
	client: move ReferenceFormatterFactory to service container	mediawiki/extensions/Wikibase	master	+62 -24

Customize query in gerrit

Related Objects

Mentioned In: T268600: Implement services through MediaWikiServices
Mentioned Here: T279995: Move WikibaseClient DataAccessSnakFormatterFactory to service container

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 19 2021, 5:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2021, 5:26 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 19 2021, 5:27 PM

Lucas_Werkmeister_WMDE claimed this task.Apr 20 2021, 11:46 AM

Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Change 681343 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] client: move ReferenceFormatterFactory to service container

https://gerrit.wikimedia.org/r/681343

gerritbot added a project: Patch-For-Review.Apr 20 2021, 11:56 AM

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 20 2021, 11:56 AM

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 20 2021, 12:04 PM

Change 681343 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: move ReferenceFormatterFactory to service container

https://gerrit.wikimedia.org/r/681343

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 20 2021, 2:33 PM

Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 20 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2021, 3:10 PM