Page MenuHomePhabricator

Move WikibaseRepo TermStoreWriterFactory to service container
Closed, ResolvedPublic

Description

Note: the method is named getNewTermStoreWriterFactory(), and always returns a new instance (i.e. there’s no $this->termStoreWriterFactory), but I suspect the “new” in the name is meant as “new term store” (aka the “2019 term store”, or just “the term store” now that we got rid of the “old” one in Wikibase wb_terms leftovers 2020), not “always returns a new instance”, and so it should be okay to move it to the service container.

Can be done after T276430: Move WikibaseRepo StringNormalizer to service container.

Event Timeline

Change 670435 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: move TermStoreWriterFactory to service container

https://gerrit.wikimedia.org/r/670435

Change 670435 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: move TermStoreWriterFactory to service container

https://gerrit.wikimedia.org/r/670435