Page MenuHomePhabricator
Create Task
Maniphest T278819

Move WikibaseRepo UserLanguage to service container
Closed, ResolvedPublic
Actions

Description

The user interface language is not available in the service container, as far as I can tell, neither directly nor as part of some context source. I assume this is because service wiring is supposed to be independent of user configuration or individual request contexts. However, several other services in Wikibase Repository depend on the user language, so I don’t think we can make do without it yet. I suggest we add it to the service wiring file (based on $wgLang), but deprecate the accessor method in WikibaseRepo and create follow-up tasks to remove uses of this service.

Details

SubjectRepoBranchLines +/-
Update calls to getUserLanguagemediawiki/extensions/WikibaseMediaInfomaster+2 -2
Update calls to getUserLanguagemediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
Pass down MediaWiki servicesmediawiki/extensions/WikibaseLexememaster+2 -2
Move WikibaseRepo UserLanguage to service containermediawiki/extensions/Wikibasemaster+86 -26
Update calls to getUserLanguagemediawiki/extensions/WikibaseLexememaster+7 -6
Update calls to getUserLanguagemediawiki/extensions/WikibaseLexemeCirrusSearchmaster+4 -4
Update calls to getUserLanguagemediawiki/extensions/WikibaseCirrusSearchmaster+6 -6
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 30 2021, 12:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2021, 12:44 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Mar 30 2021, 12:44 PM
Lucas_Werkmeister_WMDE mentioned this in T277577: Move WikibaseRepo MessageParameterFormatter to service container.
Lucas_Werkmeister_WMDE added a comment.Mar 30 2021, 12:48 PM

As far as I’m aware, the two main sources of the user language (assuming you don’t have access to an IContextSource where you can call getLanguage()) are global $wgLang and RequestContext::getMain()->getLanguage(). (Which ultimately amounts to the same thing – see StubUserLang::_newObject().) CirrusSearch’s SearchConfig.php puts it like this:

	/**
	 * Get user's language
	 * @return string User's language code
	 */
	public function getUserLanguage() {
		// I suppose using $wgLang would've been more evil than this, but
		// only marginally so. Find some real context to use here.
		return RequestContext::getMain()->getLanguage()->getCode();
	}

For our service wiring, I suggest we use $wgLang, which should be easier to mock in the unit test for this service wiring.

Lucas_Werkmeister_WMDE added a comment.Mar 30 2021, 2:22 PM

See also T218555: Provide access to WebRequest and associated information via a service object for some discussion of the user language (though it’s not the main focus of the discussion).

ItamarWMDE claimed this task.Mar 31 2021, 2:55 PM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 31 2021, 4:13 PM
Addshore subscribed.Apr 1 2021, 9:34 AM
gerritbot added a comment.Apr 1 2021, 5:14 PM

Change 676423 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseCirrusSearch@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676423

gerritbot added a project: Patch-For-Review.Apr 1 2021, 5:14 PM
gerritbot added a comment.Apr 1 2021, 5:36 PM

Change 676422 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo UserLanguage to service container

https://gerrit.wikimedia.org/r/676422

gerritbot added a comment.Apr 1 2021, 5:41 PM

Change 676428 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676428

gerritbot added a comment.Apr 1 2021, 6:14 PM

Change 676432 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676432

gerritbot added a comment.Apr 1 2021, 6:16 PM

Change 676433 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseMediaInfo@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676433

gerritbot added a comment.Apr 1 2021, 6:20 PM

Change 676434 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseQualityConstraints@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676434

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 6 2021, 9:10 AM
ItamarWMDE mentioned this in T279415: Remove calls to deprecated WikibaseRepo::getUserLanguage.Apr 6 2021, 9:23 AM

A task to track the removal of deprecated calls was created in T279415

gerritbot added a comment.Apr 6 2021, 3:21 PM

Change 677288 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Pass down MediaWiki services

https://gerrit.wikimedia.org/r/677288

gerritbot added a comment.Apr 6 2021, 4:04 PM

Change 676422 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo UserLanguage to service container

https://gerrit.wikimedia.org/r/676422

gerritbot added a comment.Apr 6 2021, 4:04 PM

Change 676428 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676428

gerritbot added a comment.Apr 6 2021, 4:04 PM

Change 676423 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676423

gerritbot added a comment.Apr 6 2021, 4:04 PM

Change 676432 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676432

ItamarWMDE mentioned this in rEWLCddbcd79cbb17: Update calls to getUserLanguage.Apr 6 2021, 4:12 PM
gerritbot added a comment.Apr 6 2021, 4:33 PM

Change 676434 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676434

gerritbot added a comment.Apr 6 2021, 4:33 PM

Change 677288 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Pass down MediaWiki services

https://gerrit.wikimedia.org/r/677288

gerritbot added a comment.Apr 6 2021, 5:02 PM

Change 676433 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Update calls to getUserLanguage

https://gerrit.wikimedia.org/r/676433

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 6 2021, 5:04 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 6 2021, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits