[EPIC] Remove calls to deprecated WikibaseRepo::getUserLanguage
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	ItamarWMDE
	Apr 6 2021, 9:23 AM

Description

Context

The UserLanguage service has been migrated to the new service container. However, it was decided in T278819 that this service should be deprecated and gradually retired out of usage, because services in the service container should be independent of a specific request context, including the user language for that request, and $wgUser will be deprecated eventually (T159299). The method itself was deprecated in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/676422.

Objective

The service accessor method is no longer called in any of the Wikibase related extensions:

Wikibase
WikibaseLexeme
WikibaseCirrusSearch
WikibaseLexemeCirrusSearch
WikibaseQualityConstraints
WikibaseMediaInfo

Code search: https://codesearch.wmcloud.org/search/?q=WikibaseRepo%3A%3AgetUserLanguage&i=nope&files=&excludeFiles=&repos=

Additional Considerations

In each of these extensions, an alternative way to obtain the user language should be found to replace calls to this method, either by utilizing the RequestContext or otherwise (in places where the request is not available).

Details

	Subject	Repo	Branch	Lines +/-
	Don’t inject user language in CheckConstraintParameters	mediawiki/extensions/WikibaseQualityConstraints	master	+85 -51
	Don’t inject user language in CheckConstraints	mediawiki/extensions/WikibaseQualityConstraints	master	+71 -43

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T279415 [EPIC] Remove calls to deprecated WikibaseRepo::getUserLanguage
Resolved	ItamarWMDE	T281365 Remove calls to WikibaseRepo::getUserLanguage from SpecialListPropertiesDispatchingFactory
Resolved	ItamarWMDE	T281449 Remove calls to WikibaseRepo::getUserLanguage from the ViewFactory Service wiring
Open	None	T281718 Remove calls to WikibaseRepo::getUserLanguage from entity search callbacks
Open	None	T281720 Remove calls to WikibaseRepo::getUserLanguage from the MessageParameterFormatter Service wiring
Resolved	Lucas_Werkmeister_WMDE	T281721 Remove calls to deprecated WikibaseRepo::getLanguageNameLookup()
Resolved	Lucas_Werkmeister_WMDE	T281712 Don’t inject LanguageNameLookup into ViewFactory
Resolved	Lucas_Werkmeister_WMDE	T281722 Stop injecting LanguageNameLookup into EntityIdHtmlLinkFormatterFactory
Resolved	Lucas_Werkmeister_WMDE	T281726 Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders
Open	None	T281724 WikibaseCirrusSearch: Remove calls to WikibaseRepo::getUserLanguage from EntityFullTextQueryBuilder
Open	None	T281725 WikibaseCirrusSearch: Remove calls to WikibaseRepo::getUserLanguage from Hooks.php
Open	None	T281799 WikibaseLexeme: Remove calls to WikibaseRepo::getUserLanguage from formatter factory callbacks
Resolved	Michael	T281801 WikibaseLexeme: Remove calls to WikibaseRepo::getUserLanguage from entity diff visualizer callbacks
Open	None	T281805 WikibaseLexemeCirrusSearch: Remove calls to WikibaseRepo::getUserLanguage from LexemeFullTextQueryBuilder
Open	None	T281807 WikibaseMediaInfo: Remove calls to WikibaseRepo::getUserLanguage from search profile callbacks
Open	None	T344050 WikibaseClient SidebarLinkBadgeDisplay inappropriately uses user language for parser output

Event Timeline

ItamarWMDE created this task.Apr 6 2021, 9:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2021, 9:23 AM

ItamarWMDE mentioned this in T278819: Move WikibaseRepo UserLanguage to service container.Apr 6 2021, 9:24 AM

Addshore moved this task from Inbox to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.Apr 6 2021, 11:53 AM

Change 677277 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t inject user language in CheckConstraintParameters

https://gerrit.wikimedia.org/r/677277

Change 677278 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t inject user language in CheckConstraints

https://gerrit.wikimedia.org/r/677278

Addshore added a project: Wikidata-Campsite.Apr 13 2021, 5:05 PM

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.

darthmon_wmde moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 22 2021, 10:16 AM

ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.Apr 27 2021, 9:45 AM

ItamarWMDE moved this task from Doing to Ready to pick up on the Wikibase Service Migration board.

Lucas_Werkmeister_WMDE closed subtask T281449: Remove calls to WikibaseRepo::getUserLanguage from the ViewFactory Service wiring as Resolved.Apr 29 2021, 2:43 PM

Lucas_Werkmeister_WMDE closed subtask T281365: Remove calls to WikibaseRepo::getUserLanguage from SpecialListPropertiesDispatchingFactory as Resolved.

Lucas_Werkmeister_WMDE mentioned this in T277464: [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests.Apr 30 2021, 9:24 AM

Change 677277 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t inject user language in CheckConstraintParameters

https://gerrit.wikimedia.org/r/677277

Change 677278 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t inject user language in CheckConstraints

https://gerrit.wikimedia.org/r/677278

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 30 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 30 2021, 5:10 PM

Lucas_Werkmeister_WMDE mentioned this in T281677: Make SummaryFormatterTest a proper unit test.May 3 2021, 8:37 AM

Lucas_Werkmeister_WMDE removed a subtask: T281712: Don’t inject LanguageNameLookup into ViewFactory.May 3 2021, 2:53 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 3 2021, 4:06 PM

Addshore updated the task description. (Show Details)Jun 23 2021, 9:07 AM

Addshore updated the task description. (Show Details)

Addshore triaged this task as Low priority.Jul 14 2021, 11:12 AM

Addshore removed a project: Wikidata-Campsite.Jul 20 2021, 2:56 PM

Lucas_Werkmeister_WMDE mentioned this in T201170: Allow wikibase to render entities for an arbitrary target language, instead of the user's UI language.Sep 17 2021, 9:44 AM

Lucas_Werkmeister_WMDE mentioned this in T344050: WikibaseClient SidebarLinkBadgeDisplay inappropriately uses user language for parser output.Aug 11 2023, 9:30 AM

Lucas_Werkmeister_WMDE subscribed.Aug 11 2023, 2:05 PM

Lucas_Werkmeister_WMDE closed subtask T281801: WikibaseLexeme: Remove calls to WikibaseRepo::getUserLanguage from entity diff visualizer callbacks as Resolved.Aug 11 2023, 2:08 PM

Lucas_Werkmeister_WMDE closed subtask T281721: Remove calls to deprecated WikibaseRepo::getLanguageNameLookup() as Resolved.Sep 20 2023, 1:18 PM

Lucas_Werkmeister_WMDE mentioned this in T377442: [GENERAL] Stop relying on Language object in Wikibase.Oct 17 2024, 12:33 PM

ItamarWMDE raised the priority of this task from Low to Needs Triage.Fri, Dec 6, 11:29 AM

ItamarWMDE added a project: wmde-wikidata-tech (DOT Triage).

ItamarWMDE edited projects, added wmde-wikidata-tech; removed wmde-wikidata-tech (DOT Triage).

ItamarWMDE renamed this task from Remove calls to deprecated WikibaseRepo::getUserLanguage to [EPIC] Remove calls to deprecated WikibaseRepo::getUserLanguage.Fri, Dec 6, 11:37 AM

ItamarWMDE updated the task description. (Show Details)

Restricted Application added a project: Epic. · View Herald TranscriptFri, Dec 6, 11:37 AM

Maintenance_bot moved this task from Triaged Low (0-50) to Sorted Team A on the [DEPRECATED] wdwb-tech board.Fri, Dec 6, 12:29 PM

ItamarWMDE moved this task from Incoming to [DOT] Prioritized Epics on the wmde-wikidata-tech board.Tue, Dec 10, 11:22 AM

[EPIC] Remove calls to deprecated WikibaseRepo::getUserLanguageOpen, Needs TriagePublicActions