Page MenuHomePhabricator
Create Task
Maniphest T281721

Remove calls to deprecated WikibaseRepo::getLanguageNameLookup()
Closed, ResolvedPublic
Actions

Description

This service requires the deprecated WikibaseRepo::getUserLanguage() and should be replaced by alternative options.

Details

SubjectRepoBranchLines +/-
Remove WikibaseRepo.LanguageNameLookup servicemediawiki/extensions/Wikibasemaster+0 -56
Inject LanguageNameLookupFactory into OutputPageBeforeHTMLHookHandlermediawiki/extensions/Wikibasemaster+11 -9
Improve SpecialItemDisambiguation service injectionmediawiki/extensions/Wikibasemaster+164 -44
Don’t use LanguageNameLookup in SpecialItemDisambiguationmediawiki/extensions/Wikibasemaster+44 -46
Don’t use LanguageNameLookup service in formatter callbacksmediawiki/extensions/WikibaseLexememaster+16 -8
Don’t use LanguageNameLookup service in HTMLContentLanguageFieldmediawiki/extensions/Wikibasemaster+7 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 3 2021, 2:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2021, 2:53 PM
Lucas_Werkmeister_WMDE added a subtask: T281712: Don’t inject LanguageNameLookup into ViewFactory.May 3 2021, 2:53 PM
Addshore moved this task from Inbox to Hike Leftovers on the [DEPRECATED] wdwb-tech board.May 3 2021, 4:33 PM
ItamarWMDE closed subtask T281712: Don’t inject LanguageNameLookup into ViewFactory as Resolved.May 4 2021, 8:12 AM
Lucas_Werkmeister_WMDE closed subtask T281722: Stop injecting LanguageNameLookup into EntityIdHtmlLinkFormatterFactory as Resolved.May 4 2021, 9:06 AM
Addshore moved this task from Hike Leftovers to Subtasks on the [DEPRECATED] wdwb-tech board.Jun 28 2021, 3:16 PM
Lucas_Werkmeister_WMDE closed subtask T281726: Stop injecting LanguageNameLookup into WikibaseValueFormatterBuilders as Resolved.Aug 11 2023, 8:52 AM
gerritbot added a comment.Aug 11 2023, 1:46 PM

Change 948138 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Don’t use LanguageNameLookup service in HTMLContentLanguageField

https://gerrit.wikimedia.org/r/948138

gerritbot added a project: Patch-For-Review.Aug 11 2023, 1:46 PM
gerritbot added a comment.Aug 22 2023, 2:18 PM

Change 948138 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Don’t use LanguageNameLookup service in HTMLContentLanguageField

https://gerrit.wikimedia.org/r/948138

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2023, 2:31 PM
gerritbot added a comment.Aug 22 2023, 3:00 PM

Change 951521 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Don’t use LanguageNameLookup service in formatter callbacks

https://gerrit.wikimedia.org/r/951521

gerritbot added a project: Patch-For-Review.Aug 22 2023, 3:00 PM
gerritbot added a comment.Aug 23 2023, 2:37 PM

Change 951948 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Don’t use LanguageNameLookup in SpecialItemDisambiguation

https://gerrit.wikimedia.org/r/951948

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 12:01 AM
gerritbot added a comment.Aug 31 2023, 8:56 AM

Change 951521 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Don’t use LanguageNameLookup service in formatter callbacks

https://gerrit.wikimedia.org/r/951521

gerritbot added a comment.Sep 8 2023, 2:20 PM

Change 955952 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Improve SpecialItemDisambiguation service injection

https://gerrit.wikimedia.org/r/955952

gerritbot added a comment.Sep 8 2023, 2:38 PM

Change 951948 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Don’t use LanguageNameLookup in SpecialItemDisambiguation

Reason:

superseded by Ia4249f7662

https://gerrit.wikimedia.org/r/951948

gerritbot added a comment.Sep 11 2023, 9:38 AM

Change 955952 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Improve SpecialItemDisambiguation service injection

https://gerrit.wikimedia.org/r/955952

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.26; 2023-09-12); removed MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 11 2023, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2023, 10:10 AM
gerritbot added a comment.Sep 11 2023, 12:50 PM

Change 956427 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Inject LanguageNameLookupFactory into OutputPageBeforeHTMLHookHandler

https://gerrit.wikimedia.org/r/956427

gerritbot added a project: Patch-For-Review.Sep 11 2023, 12:50 PM

Change 956428 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo.LanguageNameLookup service

https://gerrit.wikimedia.org/r/956428

gerritbot added a comment.Sep 12 2023, 10:21 AM

Change 956427 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Inject LanguageNameLookupFactory into OutputPageBeforeHTMLHookHandler

https://gerrit.wikimedia.org/r/956427

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 12 2023, 11:00 AM
Lucas_Werkmeister_WMDE claimed this task.Sep 20 2023, 10:19 AM
gerritbot added a comment.Sep 20 2023, 11:18 AM

Change 956428 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo.LanguageNameLookup service

https://gerrit.wikimedia.org/r/956428

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2023, 11:32 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 20 2023, 12:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Sep 20 2023, 1:18 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Done on the Wikibase Service Migration board.

Done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits