Page MenuHomePhabricator

WikibaseLexeme: Remove calls to WikibaseRepo::getUserLanguage from entity diff visualizer callbacks
Closed, ResolvedPublic

Description

Currently, the ENTITY_DIFF_VISUALIZER_CALLBACK functions in WikibaseLexeme.entitytypes.php call the deprecated UserLanguage service from WikibaseRepo. In order to retire this service, we will need to find a way to obtain the language in a more appropriate way, either via RequestConext or by making using the globals directly rather than through Wikibase.

Event Timeline

Lucas_Werkmeister_WMDE assigned this task to Michael.

This effectively got resolved in Lexemes and Forms don't have Labels, so don't try to look them up – the user language was only being used to create a LanguageFallbackLabelDescriptionLookup, but that’s a pointless service for lexemes/forms/senses, so it was replaced with a null implementation that doesn’t need a language.