Page MenuHomePhabricator
Create Task
Maniphest T279939

Move WikibaseRepo ItemHandler to service container
Closed, ResolvedPublic
Actions

Description

Can be done after T279659: Move WikibaseRepo EntityContentDataCodec to service container, T279516: WikibaseRepo: Move ValidatorErrorLocalizer to service container, T279769: Move WikibaseRepo LegacyFormatDetectorCallback to service container, and T279526: Move WikibaseRepo PropertyDataTypeLookup to service container. (I suggest inlining getFieldDefinitionsByType().)

Details

SubjectRepoBranchLines +/-
repo: move ItemHandler to service containermediawiki/extensions/Wikibasemaster+109 -54
Remove WikibaseRepo::newItemHandler()mediawiki/extensions/Wikibasemaster+0 -7
Update WikibaseRepo::newItemHandler() callmediawiki/extensions/WikibaseCirrusSearchmaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 12 2021, 3:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2021, 3:49 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Apr 12 2021, 3:49 PM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Apr 13 2021, 9:15 AM
Lucas_Werkmeister_WMDE claimed this task.Apr 13 2021, 10:39 AM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE added a comment.Apr 13 2021, 10:46 AM

I suggest inlining getFieldDefinitionsByType().

On second thought, since this is used for several entity types both in Wikibase and in other extensions, it’s probably worth it to extract a service for this.

gerritbot added a comment.Apr 13 2021, 2:31 PM

Change 678853 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: move ItemHandler to service container

https://gerrit.wikimedia.org/r/678853

gerritbot added a project: Patch-For-Review.Apr 13 2021, 2:31 PM

Change 678854 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::newItemHandler() call

https://gerrit.wikimedia.org/r/678854

gerritbot added a comment.Apr 13 2021, 2:32 PM

Change 678855 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo::newItemHandler()

https://gerrit.wikimedia.org/r/678855

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 13 2021, 2:33 PM
gerritbot added a comment.Apr 14 2021, 12:02 PM

Change 678853 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: move ItemHandler to service container

https://gerrit.wikimedia.org/r/678853

gerritbot added a comment.Apr 14 2021, 12:05 PM

Change 678854 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Update WikibaseRepo::newItemHandler() call

https://gerrit.wikimedia.org/r/678854

gerritbot added a comment.Apr 14 2021, 12:05 PM

Change 678855 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo::newItemHandler()

https://gerrit.wikimedia.org/r/678855

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 14 2021, 12:10 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Maintenance_bot removed a project: Patch-For-Review.Apr 14 2021, 12:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 14 2021, 1:00 PM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 15 2021, 4:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits