Change Details

Current logic sometimes passes the keydown to a handler that may expand the menu or select a menu item if one is highlighted. However, this can be tricky to get right and recently caused a bug (T324397). We decided to remove special handling of the space key for any menu component that has a text input, to ensure that a space keypress always results in a space character in the text input. This was done for Lookup as part of the fix for T324397, and needs to be done for TypeaheadSearch and Combobox. --- ### Acceptance criteria - [x] Logic is updated for TypeaheadSearch - [x] Logic is updated for Combobox

Current logic sometimes passes the keydown to a handler that may expand the menu or select a menu item if one is highlighted. However, this can be tricky to get right and recently caused a bug (T324397). We decided to remove special handling of the space key for any menu component that has a text input, to ensure that a space keypress always results in a space character in the text input. This was done for Lookup as part of the fix for T324397, and needs to be done for TypeaheadSearch and Combobox. --- ### Acceptance criteria - [x] Logic is updated for TypeaheadSearch - [x] Logic is updated for Combobox - [] Change demos on Menu page to reflect this new behavior

Current logic sometimes passes the keydown to a handler that may expand the menu or select a menu item if one is highlighted. However, this can be tricky to get right and recently caused a bug (T324397). We decided to remove special handling of the space key for any menu component that has a text input, to ensure that a space keypress always results in a space character in the text input. This was done for Lookup as part of the fix for T324397, and needs to be done for TypeaheadSearch and Combobox. --- ### Acceptance criteria - [x] Logic is updated for TypeaheadSearch - [x] Logic is updated for Combobox - [] Change demos on Menu page to reflect this new behavior