Always allow default behavior of space key for menu components with text inputs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	AnneT
	Dec 8 2022, 8:55 PM

Description

Current logic sometimes passes the keydown to a handler that may expand the menu or select a menu item if one is highlighted. However, this can be tricky to get right and recently caused a bug (T324397).

We decided to remove special handling of the space key for any menu component that has a text input, to ensure that a space keypress always results in a space character in the text input. This was done for Lookup as part of the fix for T324397, and needs to be done for TypeaheadSearch and Combobox.

Acceptance criteria

Logic is updated for TypeaheadSearch
Logic is updated for Combobox
Change demos on Menu page to reflect this new behavior

Details

Subject	Repo	Branch	Lines +/-
Update Codex from v0.4.3 to v0.5.0	mediawiki/core	master	+1 K -1 K
docs: Align Menu demos with keyboard navigation standards	design/codex	main	+103 -9
Update Codex from v0.4.0 to v0.4.2	mediawiki/core	master	+72 -72
Combobox, TypeaheadSearch: Always allow default behavior of space key for menu components with text inputs.	design/codex	main	+31 -11

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T324794 Consider changing handling of space key for menu components
		Resolved		Jrbranaa	T324792 Always allow default behavior of space key for menu components with text inputs

Event Timeline

AnneT created this task.Dec 8 2022, 8:55 PM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptDec 8 2022, 8:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

AnneT added a parent task: T324794: Consider changing handling of space key for menu components.Dec 8 2022, 9:03 PM

Ddwaal claimed this task.Dec 8 2022, 10:37 PM

Change 866642 had a related patch set uploaded (by Dani DW; author: Dani DW):

[design/codex@main] Combobox, TypeaheadSearch

https://gerrit.wikimedia.org/r/866642

gerritbot added a project: Patch-For-Review.Dec 9 2022, 8:02 PM

Change 866642 merged by jenkins-bot:

[design/codex@main] Combobox, TypeaheadSearch: Always allow default behavior of space key for menu components with text inputs.

https://gerrit.wikimedia.org/r/866642

AnneT changed the task status from Open to In Progress.Dec 12 2022, 7:25 PM

AnneT edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.

AnneT updated the task description. (Show Details)

AnneT moved this task from Committed to Design Sign-Off on the Design-System-Team (Design-System-Sprint) board.

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2022, 7:30 PM

Change 867727 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.4.0 to v0.4.1

https://gerrit.wikimedia.org/r/867727

gerritbot added a project: Patch-For-Review.Dec 13 2022, 10:53 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cb9ffaffec/w

Change 867727 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.4.0 to v0.4.2

https://gerrit.wikimedia.org/r/867727

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2022, 12:30 AM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/cb9ffaffec/w/~~

egardner reassigned this task from Ddwaal to • EUdoh-WMF.Dec 20 2022, 10:56 PM

egardner moved this task from Design Sign-Off to QTE Sign-off on the Design-System-Team (Design-System-Sprint) board.

Assigning back to myself to rethink the demos on the Menu page, which use a text input that doesn't yet reflect this new behavior.

AnneT updated the task description. (Show Details)Jan 23 2023, 5:50 PM

Change 883663 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] docs: Align Menu demos with keyboard navigation standards

https://gerrit.wikimedia.org/r/883663

gerritbot added a project: Patch-For-Review.Jan 25 2023, 9:48 PM

Change 883663 merged by jenkins-bot:

[design/codex@main] docs: Align Menu demos with keyboard navigation standards

https://gerrit.wikimedia.org/r/883663

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2023, 1:30 AM

The Menu demos have been updated to match the desired behavior (the space key always inserts a space character, rather than toggling the menu), so this is ready for final QTE signoff

ldelench_wmf triaged this task as High priority.Jan 27 2023, 4:21 PM

Change 869852 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/869852

gerritbot added a project: Patch-For-Review.Jan 31 2023, 11:42 PM

Change 885450 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/885450

Change 885450 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/885450

ldelench_wmf reassigned this task from • EUdoh-WMF to Jrbranaa.Feb 13 2023, 3:38 PM