F24103948 (I have no idea if you can see it on non-apple devices but anyway)
Version: `5.8.2 (1421) Beta`
Download something into reading list, and enter airplane mode. When you start reading the articles in 'reading list', "Syncing will resume when internet available" never disappears. It just keep appearing despite manually removing it, just ignoring it, whatever I do or don't. I gave up reading because it was too annoying for me. So, this notice should disappear at some point.
--------
NOTE: It looks like @JoeWalsh fixed the issue described above but in attempting to repro it I found some missing empty / error states
===User story
As a user who has no internet access, I would like to see a more actionable message regarding my lack of internet access.
===Mocks
| Searching while offline | Reloading a synced article while offline
|--- |---
| {F27891788 width=220} | {F27891687 width=220}
|Zeplin: https://zpl.io/V1zBRKJ | Zeplin: https://zpl.io/bzAZPgM
===Design details
**Searching while offline**
This message would show even before a user begins typing and would not change regardless of what the user types. Tapping try again would refresh the screen.
In this case we should NOT show the user the toast message.
**Reloading a synced article while offline**
Currently when a user pulls down to refresh an article while offline, they receive a message that they are offline and the article which was previously loaded is replaced with a message saying that the article cannot be loaded, tapping 'back' then brings them to whatever screen they were on before they opened that article.
Instead of doing the behavior described above, the new behavior would be to show a user education overlay saying that they do not have an internet connection, but they can tap through the CTA to return to the last saved version.
In this case we should NOT show the user the toast message.