Given our new feature flagged approach it doesn't seem helpful having two files to look in for skins.
It also seems to be creating code debt for us and is making it hard for us to enable code in production (we tend to have "prepare X for production" cards).
Can I suggest we stop using this and merge the code in SkinMinervaBeta and SkinMinerva?
Note: We can still support a beta mode using a feature flagging approach. in the new system beta rather than switching the skin class, the SkinMinerva constructor could enable all feature flags in the construct stepis not helpful to use whether a user is in stable or beta as an indication that a feature is enabled. Removing beta at this stage is out of scope.
Suggested changes:We have done a lot of work to remove the SkinMinervaBeta class and its friends and introduce feature flagging which allows us to control which features are enabled on stable or beta via a config change.
= Work so far
[x] Cleanup dead code (there's lots of it: https://gerrit.wikimedia.org/r/315540 )
Beta differs from stable in several ways let's clean this up:
[x] ~~We currently load a talk icon for the talk button . Make a decision on T142976 (In meantime I suggest moving the existing beta only flagged code to stable)~~ (no longer valid)
[x] We currently disable CentralNotice on beta. Let's remove that logic and enable it in beta too.
[x] ~~Fontchanger should be feature flagged and enabled inside SkinMinerva.php~~ (see the subtask T148193)
[x] Back to top should be feature flagged and enabled inside SkinMinerva.php
~~Wait for the outcome of T148199~~:
[x] remove the `skins.minerva.beta.scripts`
Let's complete the transition
[x] Remove SkinMinervaBeta.php
[x] Remove MinervaTemplateBeta
== Remaining work
[] Resolve the 2 remaining subtasks
[] With subtasks resolved, submit a patch associated with this task that drops resources/mobile.startup/context.js will be dropped from codebase and this ticket can be closed.from the codebase
== Estimation notes
If estimating this task do so for the final subtask. It doesn't seem helpful at this time to create another subtask just for that.