Change Details

Now that T218340 is working, we can see certain use cases that are not being handled correctly. This ticket adjusts the messaging for these. (It also adds one small text change to the Categories filtering panel.) = 1) Totals not yet calculated There is a pre-existing, Grant Metrics state I didn't know about that shows up whenever the user has __not yet calculated totals__ after Saving Settings (whether during initial setup or after a subsequent Settings change is irrelevant). In such cases, the "Update data" button is instead called "Calculate totals," and a green banner at page top shows up with some messaging we don't need. The items below show how to fix this messaging for the Unfiltered, Partial and Valid states. ( Note that in no case should there ever be two green banners.) ===Any UNFILTERED STATE - Do not show the top green banner. - Other than that, it looks fine. {F28479688 width = 450} ===Any PARTIAL states where the user has NOT YET CALCULATED TOTALS since Saving Settings (including Partial state with Wikidata) - Do not show the top green banner. - For the subtitle, use "Calculate totals" language instead of the "Update data" language, like so: - "You will get metrics for some but not all of the wikis specified for the event. Click __Calculate totals__ to get metrics." - Note: In cases where the event is in Partial but the user HAS "Calculated totals" after saving, continue to use the "Update data" messaging defined in T218340, as now. {F28479826 width = 450} ===VALID states where the user has NOT YET CALCULATED TOTALS since Saving Settings - Do not show the top green banner. Show only the one above the filters. - For the subtitle, use "calculate totals" language instead of the "update data" language, like so (actually, I've rewritten this whole message, FYI): - "Event settings saved successfully. Click __Calculate totals__ to get metrics. " - Note: the green banner should be shown only when all filters saved are valid. If there are invalid entries, follow the instructions in T219464. {F28479979 width = 450} = 2) This event is in the Future Another message not accounted for in the design is the one pictured below, which appears when the event takes place in the future. - Do not show the top green banner. - To display the message, use the Partial style (yellow) Error box with the following title/subtitle: - **This event takes place in the future** - Statistics can't be generated yet. If you want to change dates, go to __Settings__. [Where clicking Settings takes the user to the Event Settings page.] {F28490064 width = 450} = 3) Text change to Categories filtering panel Alex and Sati asked us to add another line to the instruction text for Categories. Because this makes the instruction text a bit long, we will break it up into two lines, with bullets. Prateek has provided code to show styling for this. [[ https://prtksxna.github.io/wmf-prototype-gm/event-filter-incomplete.html | Here is Prateek's mockup with the code for this ]]. Here is the new text (the only new bit is the first bullet). **Enter categories (with wiki names) to limit metrics to pages in those categories.** - Categories must be on main namespace pages; hidden categories are allowed. !![this is the NEW bit]!! - On Commons only, use this tool to filter files (images, videos, etc.), instead of pages.

Now that T218340 is working, we can see certain use cases that are not being handled correctly. This ticket adjusts the messaging for these. (It also adds one small text change to the Categories filtering panel.) = 1) Totals not yet calculated There is a pre-existing, Grant Metrics state I didn't know about that shows up whenever the user has __not yet calculated totals__ after Saving Settings (whether during initial setup or after a subsequent Settings change is irrelevant). In such cases, the "Update data" button is instead called "Calculate totals," and a green banner at page top shows up with some messaging we don't need. The items below show how to fix this messaging for the Unfiltered, Partial and Valid states. ( Note that in no case should there ever be two green banners.) ===Any UNFILTERED STATE - Do not show the top green banner. - Other than that, it looks fine. {F28479688 width = 450} ===Any PARTIAL states where the user has NOT YET CALCULATED TOTALS since Saving Settings (including Partial state with Wikidata) - Do not show the top green banner. - For the subtitle, use "Calculate totals" language instead of the "Update data" language, like so: - "You will get metrics for some but not all of the wikis specified for the event. Click __Calculate totals__ to get metrics." - Note: In cases where the event is in Partial but the user HAS "Calculated totals" after saving, continue to use the "Update data" messaging defined in T218340, as now. {F28479826 width = 450} ===VALID states where the user has NOT YET CALCULATED TOTALS since Saving Settings - Do not show the top green banner. Show only the one above the filters. - For the subtitle, use "calculate totals" language instead of the "update data" language, like so (actually, I've rewritten this whole message, FYI): - "Event settings saved successfully. Click __Calculate totals__ to get metrics. " - Note: the green banner should be shown only when all filters saved are valid. If there are invalid entries, follow the instructions in T219464. {F28479979 width = 450} = 2) This event is in the Future Another message not accounted for in the design is the one pictured below, which appears when the event takes place in the future. - Do not show the top green banner. - To display the message, use the Partial style (yellow) Error box with the following title/subtitle: - **This event takes place in the future** - Statistics can't be generated yet. If you want to change dates, go to __Settings__. [Where clicking Settings takes the user to the Event Settings page.] {F28490064 width = 450} = 3) Text change to Categories filtering panel Alex and Sati asked us to add another line to the instruction text for Categories. Because this makes the instruction text a bit long, we will break it up into two lines, with bullets. Prateek has provided code to show styling for the bullets, since we haven't used them in that spot before. [[ https://prtksxna.github.io/wmf-prototype-gm/event-filter-incomplete.html | Here is Prateek's mockup with the code for this ]]. Here is the new text (the only new bit is the first bullet). **Enter categories (with wiki names) to limit metrics to pages in those categories.** - Categories must be on main namespace pages; hidden categories are allowed. !![this is the NEW bit]!! - On Commons only, use this tool to filter files (images, videos, etc.), instead of pages.

Now that T218340 is working, we can see certain use cases that are not being handled correctly. This ticket adjusts the messaging for these. (It also adds one small text change to the Categories filtering panel.) = 1) Totals not yet calculated There is a pre-existing, Grant Metrics state I didn't know about that shows up whenever the user has __not yet calculated totals__ after Saving Settings (whether during initial setup or after a subsequent Settings change is irrelevant). In such cases, the "Update data" button is instead called "Calculate totals," and a green banner at page top shows up with some messaging we don't need. The items below show how to fix this messaging for the Unfiltered, Partial and Valid states. ( Note that in no case should there ever be two green banners.) ===Any UNFILTERED STATE - Do not show the top green banner. - Other than that, it looks fine. {F28479688 width = 450} ===Any PARTIAL states where the user has NOT YET CALCULATED TOTALS since Saving Settings (including Partial state with Wikidata) - Do not show the top green banner. - For the subtitle, use "Calculate totals" language instead of the "Update data" language, like so: - "You will get metrics for some but not all of the wikis specified for the event. Click __Calculate totals__ to get metrics." - Note: In cases where the event is in Partial but the user HAS "Calculated totals" after saving, continue to use the "Update data" messaging defined in T218340, as now. {F28479826 width = 450} ===VALID states where the user has NOT YET CALCULATED TOTALS since Saving Settings - Do not show the top green banner. Show only the one above the filters. - For the subtitle, use "calculate totals" language instead of the "update data" language, like so (actually, I've rewritten this whole message, FYI): - "Event settings saved successfully. Click __Calculate totals__ to get metrics. " - Note: the green banner should be shown only when all filters saved are valid. If there are invalid entries, follow the instructions in T219464. {F28479979 width = 450} = 2) This event is in the Future Another message not accounted for in the design is the one pictured below, which appears when the event takes place in the future. - Do not show the top green banner. - To display the message, use the Partial style (yellow) Error box with the following title/subtitle: - **This event takes place in the future** - Statistics can't be generated yet. If you want to change dates, go to __Settings__. [Where clicking Settings takes the user to the Event Settings page.] {F28490064 width = 450} = 3) Text change to Categories filtering panel Alex and Sati asked us to add another line to the instruction text for Categories. Because this makes the instruction text a bit long, we will break it up into two lines, with bullets. Prateek has provided code to show styling for thisthe bullets, since we haven't used them in that spot before. [[ https://prtksxna.github.io/wmf-prototype-gm/event-filter-incomplete.html | Here is Prateek's mockup with the code for this ]]. Here is the new text (the only new bit is the first bullet). **Enter categories (with wiki names) to limit metrics to pages in those categories.** - Categories must be on main namespace pages; hidden categories are allowed. !![this is the NEW bit]!! - On Commons only, use this tool to filter files (images, videos, etc.), instead of pages.