Change Details

**Story** As a logged-in user, I want the ability to explicitly state whether I want hovercards or not without being part of the a/b test **Description** Change hovercards a/b test control and test groups such that: Hovercards off: - Anonymous users that fall into control group as per sampling rate - Logged-in users who have hovercards off (including those who explicitly disabled hovercards and those who have taken no action) Hovercards on: - Anonymous users within test bucket - Logged-in users who have hovercards on via enabling beta - Anonymous users who enabled hovercards via link at bottom of page Notes: - Hide cog icon for logged-in users within hovercards - users will turn hovercards on/off using beta features - Hide "show previews" link at bottom of page

**Story** As a logged-in user, I want the ability to explicitly state whether I want hovercards or not without being part of the a/b test **Description** As a logged in user, my selection on beta features should always take preference over bucketing. Failing test case: >>! In T146017#2651782, @Jhernandez wrote: > > 1. Visit as anon, get bucketed in group A (hovercards ON) > 2. Hovercards work > 3. Proceed to log in to your user account (which has beta feature hovercards OFF) > 4. After you log in, see that you are still seeing hovercards, even if you didn't select the beta feature ON. > **Detailed steps** (you need a user account with hovercards beta feature off in http://reading-web-staging.wmflabs.org/): 1. Visit http://reading-web-staging.wmflabs.org/wiki/Main_Page in a new private/incognito window and wait for the page to **fully** load 2. If you can see `Enable previews` in the footer link, then close the window and try again (goto 1) 3. Once you don't see that link, verify by hovering over [[Test]] that you can see a hovercard. That means you've been bucketed as group A. 4. Proceed to login into your no-hovercards-beta-feature user account 5. Log in and go back to main page |**Expected**|Hovering over [[Test]] doesn't show a hovercard because on my user account i don't have the beta feature enabled| |**Actual**|Hovering over [[Test]] shows a hovercard| ==Tech== For logged in users, return here https://github.com/wikimedia/mediawiki-extensions-Popups/blob/master/resources/ext.popups.experiment.js#L76-L79 instead of falling through to returning the bucketing token. This will break unit tests and all the browser for settings that are based on logged in users.

**Story** As a logged-in user, I want the ability to explicitly state whether I want hovercards or not without being part of the a/b test **Description** Change hovercards a/b test control and test groups such that:As a logged in user, my selection on beta features should always take preference over bucketing. HFailing test case: >>! In T146017#2651782, @Jhernandez wrote: > > 1. Visit as anon, get bucketed in group A (hovercards off:ON) - Anonymous users that fall into control group as per sampling rate> 2. Hovercards work - Logged-in users who have hovercards off (including those who explicitly disabled hovercards and those who have taken no action) Hovercards on:> 3. Proceed to log in to your user account (which has beta feature hovercards OFF) - Anonymous users within test bucket> 4. After you log in, see that you are still seeing hovercards, even if you didn't select the beta feature ON. - Logged-in users who have hovercards on via enabling beta> - Anonymous**Detailed steps** (you need a users who enabled account with hovercards via link at bottom of pagebeta feature off in http://reading-web-staging.wmflabs.org/): Notes:1. Visit http://reading-web-staging.wmflabs.org/wiki/Main_Page in a new private/incognito window and wait for the page to **fully** load - Hide cog icon for logged-in users within hovercards - users will turn hovercards on/off using beta features - Hide "show previews" link at bottom of page2. If you can see `Enable previews` in the footer link, then close the window and try again (goto 1) 3. Once you don't see that link, verify by hovering over [[Test]] that you can see a hovercard. That means you've been bucketed as group A. 4. Proceed to login into your no-hovercards-beta-feature user account 5. Log in and go back to main page |**Expected**|Hovering over [[Test]] doesn't show a hovercard because on my user account i don't have the beta feature enabled| |**Actual**|Hovering over [[Test]] shows a hovercard| ==Tech== For logged in users, return here https://github.com/wikimedia/mediawiki-extensions-Popups/blob/master/resources/ext.popups.experiment.js#L76-L79 instead of falling through to returning the bucketing token. This will break unit tests and all the browser for settings that are based on logged in users.