Change Details

Currently WikibaseCirrusSearch has zero browser tests. While it has unit tests for the most functionality, unit tests do not guarantee that the whole roundtrip for search works, and there have been instances where all unit tests pass, but search functionality is broken. It would be nice to have functional test suite for the search ensuring that basic functionality and keywords work as expected. Since CirrusSearch tests right now run on cindy, it could probably make sense to run this part on cindy too...

Currently WikibaseCirrusSearch has zero browser tests. While it has unit tests for the most functionality, unit tests do not guarantee that the whole roundtrip for search works, and there have been instances where all unit tests pass, but search functionality is broken. It would be nice to have functional test suite for the search ensuring that basic functionality and keywords work as expected. Since CirrusSearch tests right now run on cindy, it could probably make sense to run this part on cindy too. Or make our standard CI selenium tests to be able to support CirrusSearch tests.

Currently WikibaseCirrusSearch has zero browser tests. While it has unit tests for the most functionality, unit tests do not guarantee that the whole roundtrip for search works, and there have been instances where all unit tests pass, but search functionality is broken. It would be nice to have functional test suite for the search ensuring that basic functionality and keywords work as expected. Since CirrusSearch tests right now run on cindy, it could probably make sense to run this part on cindy too.. Or make our standard CI selenium tests to be able to support CirrusSearch tests.