Page MenuHomePhabricator

Add selenium tests to WikibaseCirrusSearch
Open, MediumPublic

Description

Currently WikibaseCirrusSearch has zero browser tests. While it has unit tests for the most functionality, unit tests do not guarantee that the whole roundtrip for search works, and there have been instances where all unit tests pass, but search functionality is broken. It would be nice to have functional test suite for the search ensuring that basic functionality and keywords work as expected.

Since CirrusSearch tests right now run on cindy, it could probably make sense to run this part on cindy too. Or make our standard CI selenium tests to be able to support CirrusSearch tests.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2019, 9:54 AM

Change 608983 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikibaseCirrusSearch@master] tests: Remove empty placeholder for selenium tests

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/ /608983

Change 608984 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikibaseCirrusSearch@master] [WIP] tests: Add first selenium test

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/ /608984

Change 608983 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] tests: Remove empty placeholder for selenium tests

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/ /608983

Change 608984 abandoned by Krinkle:
[mediawiki/extensions/WikibaseCirrusSearch@master] [WIP] tests: Add first selenium test

Reason:

https://gerrit.wikimedia.org/r/608984

CBogen raised the priority of this task from Low to Medium.Aug 27 2020, 8:32 PM