HomePhabricator

Transactions T85852 Change Details

Change Details

Old
New
Diff

The "Done" button doesn't go well with VisualEditor's Find And Replace bar. It should probably say something like "Close". This is closely related to T72281: "Done" doesn't actually refer to a dialog that didn't make any changes. I am calling this "unbreak now" because this button is probably going to be deployed soonish.

The "Done" button doesn't go well with VisualEditor's Find And Replace bar. It should probably say something like "Close". This is closely related to T72281: "Done" doesn't actually refer to a dialog that didn't make any changes. I am calling this "unbreak now" because this button is probably going to be deployed soonish.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits