Change Details

=== Description Vector menus all use the 'vector-menu-heading' class, but our CSS usually directly uses `h3` in the selectors. Using the class will reduce CSS specificity and is more readable/maintainable long term because the styles are less dependent on the HTML. We also want to replace the h3 element in modern vector with a non heading element like a div to avoid messing up the heading structure === AC [] Instances of `h3` are removed from Menu CSS and replaced with `vector-menu-heading` [] `h3` elements are replaced with `label` elements in modern vector [] All styles remain the same in Vector

=== Description Vector menus all use the 'vector-menu-heading' class, but our CSS usually directly uses `h3` in the selectors. Using the class will reduce CSS specificity and is more readable/maintainable long term because the styles are less dependent on the HTML. We also want to replace the h3 element in modern vector with a non heading element like a div to avoid messing up the heading structure === AC [] Instances of `h3` are removed from Menu CSS and replaced with `vector-menu-heading` [] `h3` elements are replaced with `label` elements in modern vector [] All menu styles remain the same in Vector and legacy Vector. Menus in this context include all "dropdown menus", "tab menus", and "portlet menus" (https://phabricator.wikimedia.org/F34972677)

=== Description Vector menus all use the 'vector-menu-heading' class, but our CSS usually directly uses `h3` in the selectors. Using the class will reduce CSS specificity and is more readable/maintainable long term because the styles are less dependent on the HTML. We also want to replace the h3 element in modern vector with a non heading element like a div to avoid messing up the heading structure === AC [] Instances of `h3` are removed from Menu CSS and replaced with `vector-menu-heading` [] `h3` elements are replaced with `label` elements in modern vector [] All menu styles remain the same in Vector and legacy Vector. Menus in this context include all "dropdown menus", "tab menus", and "portlet menus" (https://phabricator.wikimedia.org/F34972677)