Page MenuHomePhabricator
Create Task
Maniphest T132352

Filters by triage state for Plagiabot tool labs interface
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Add a box at the top of the interface, with radio buttons to filter by triage state

Options:

  • Open cases - all items that have not been reviewed (default state)
  • All "Page fixed" cases
  • All "No action needed" cases
  • My reviews - items that have been reviewed by the user viewing the page.

Changing the radio button and clicking Submit reloads the page with the selected filter.

copy patrol filters 2 - wikiprojects selected.jpg (194×1 px, 32 KB)

The WikiProjects filter is on T132350: Add interface to filter by WikiProject to CopyPatrol

Related Objects
Search...

Event Timeline

kaldari created this task.Apr 11 2016, 4:13 PM
kaldari added a subtask: T132079: Add interface to tool labs interface for Plagiabot for setting triage state.
• DannyH moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Apr 11 2016, 5:06 PM
• DannyH updated the task description. (Show Details)Apr 16 2016, 12:19 AM
• DannyH removed a project: CopyPatrol.Apr 18 2016, 10:40 PM
• DannyH renamed this task from Add interface to filter by triage state to tool labs interface for Plagiabot to Filters by triage state for Plagiabot tool labs interface.May 5 2016, 11:28 PM
• DannyH updated the task description. (Show Details)
• DannyH updated the task description. (Show Details)
• DannyH updated the task description. (Show Details)May 5 2016, 11:48 PM
• DannyH mentioned this in T132350: Add interface to filter by WikiProject to CopyPatrol.May 5 2016, 11:55 PM
kaldari closed subtask T132079: Add interface to tool labs interface for Plagiabot for setting triage state as Resolved.May 17 2016, 12:17 AM
• DannyH added a project: CopyPatrol.May 18 2016, 8:56 PM
• DannyH edited projects, added Community-Tech-Sprint; removed Community-Tech.May 24 2016, 6:02 PM
• DannyH set the point value for this task to 5.
MusikAnimal claimed this task.Jun 14 2016, 2:23 PM
MusikAnimal moved this task from Ready to In Development on the Community-Tech-Sprint board.
• DannyH merged a task: T132830: Add interface to filter by triage status to Copy Patrol .Jun 14 2016, 4:30 PM
MusikAnimal added a comment.Jun 14 2016, 10:26 PM

@Niharika @kaldari pull request at https://github.com/Niharika29/PlagiabotWeb/pull/3

Regarding the interface (cc. @DannyH)

  • I added an "All cases" option, which I think we need, but we might want "Open cases" to be the default
  • The "My reviews" option is hidden if they are logged out
kaldari added a comment.Jun 14 2016, 10:40 PM

@MusikAnimal: Left some comments in GitHub.

• DannyH added a comment.Jun 14 2016, 10:52 PM

@MusikAnimal Yeah, "All cases" is a good idea, with open cases as the default.

Niharika closed this task as Resolved.Jun 16 2016, 7:33 PM

Looks good. Merged.

Niharika moved this task from In Development to Q1 2018-19 on the Community-Tech-Sprint board.Jun 16 2016, 7:33 PM
Niharika added a comment.Jun 17 2016, 1:08 PM

@DannyH I did some more testing on this and I think a filter for "All reviewed cases" would be more useful than one for all fixed and one for all not-needed ones. It'd basically give a feed of all reviews that have been made on the tool.

• DannyH added a comment.Jun 17 2016, 4:34 PM

@Niharika Yeah, that does make sense. It's a better fit for the request for an archive. Should we make another ticket?

Niharika added a comment.Jun 17 2016, 4:40 PM
In T132352#2388931, @DannyH wrote:

@Niharika Yeah, that does make sense. It's a better fit for the request for an archive. Should we make another ticket?

We can reuse this one. It should be a trivial change.
CC @MusikAnimal

MusikAnimal added a comment.Jun 17 2016, 5:19 PM

Yes that makes sense to me too, and indeed is easy to implement.

MusikAnimal added a comment.Jun 17 2016, 5:39 PM

Pull request at https://github.com/Niharika29/PlagiabotWeb/pull/6

• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Jun 20 2016, 8:09 PM
• DannyH moved this task from Needs Discussion to Archive on the Community-Tech board.Jun 20 2016, 8:19 PM
MusikAnimal moved this task from Backlog to Done on the CopyPatrol board.Dec 6 2016, 5:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL