Page MenuHomePhabricator
Create Task
Maniphest T145044

Clicking undo on an edit that changed the content model results in a MWException
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

[V9DF6QpAEK0AAC8UbGwAAABI] /w/index.php?title=Law2&action=edit&undoafter=296827&undo=296828 MWException from line 570 of /srv/mediawiki/php-1.28.0-wmf.18/includes/content/ContentHandler.php: Bad content model: expected json but got wikitext.

Backtrace:

#0 /srv/mediawiki/php-1.28.0-wmf.18/includes/content/ContentHandler.php(1023): ContentHandler->checkModelID(string)
#1 /srv/mediawiki/php-1.28.0-wmf.18/includes/page/WikiPage.php(1352): ContentHandler->getUndoContent(Revision, Revision, Revision)
#2 /srv/mediawiki/php-1.28.0-wmf.18/includes/EditPage.php(1128): WikiPage->getUndoContent(Revision, Revision)
#3 /srv/mediawiki/php-1.28.0-wmf.18/includes/EditPage.php(1046): EditPage->getContentObject(boolean)
#4 /srv/mediawiki/php-1.28.0-wmf.18/includes/EditPage.php(606): EditPage->initialiseForm()
#5 /srv/mediawiki/php-1.28.0-wmf.18/includes/actions/EditAction.php(59): EditPage->edit()
#6 /srv/mediawiki/php-1.28.0-wmf.18/includes/MediaWiki.php(505): EditAction->show()
#7 /srv/mediawiki/php-1.28.0-wmf.18/includes/MediaWiki.php(289): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.28.0-wmf.18/includes/MediaWiki.php(750): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.28.0-wmf.18/includes/MediaWiki.php(521): MediaWiki->main()
#10 /srv/mediawiki/php-1.28.0-wmf.18/index.php(43): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

When visiting https://test2.wikipedia.org/w/index.php?title=Law2&action=edit&undoafter=296827&undo=296828.

Details

SubjectRepoBranchLines +/-
API: When undoing an edit, allow overriding content model.mediawiki/coremaster+73 -7
Allow undoing edits that change content model if topmediawiki/coremaster+43 -15
Don't throw exceptions in ContentHandler::getUndoContent()mediawiki/coremaster+9 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Sep 8 2016, 2:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2016, 2:05 AM
Legoktm mentioned this in T85847: Grant editcontentmodel right to all logged in users.Sep 8 2016, 2:05 AM
gerritbot subscribed.Sep 8 2016, 4:01 AM

Change 309234 had a related patch set uploaded (by Legoktm):
Don't throw exceptions in ContentHandler::getUndoContent()

https://gerrit.wikimedia.org/r/309234

gerritbot added a project: Patch-For-Review.Sep 8 2016, 4:01 AM
gerritbot added a comment.Sep 8 2016, 5:07 AM

Change 309234 merged by jenkins-bot:
Don't throw exceptions in ContentHandler::getUndoContent()

https://gerrit.wikimedia.org/r/309234

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 8 2016, 6:00 AM
Legoktm added a comment.Sep 8 2016, 7:03 AM

Fixed the exception at least. Still doing a little digging to see if we can make undo actually undo the content model change, but that is looking rather complicated so far... :/

Jdforrester-WMF subscribed.Sep 9 2016, 12:11 AM
gerritbot added a comment.Sep 9 2016, 3:20 AM

Change 309490 had a related patch set uploaded (by Legoktm):
API: When undoing an edit, allow overriding content model.

https://gerrit.wikimedia.org/r/309490

gerritbot added a comment.Sep 9 2016, 3:20 AM

Change 309480 had a related patch set uploaded (by Legoktm):
Allow undoing edits that change content model if top

https://gerrit.wikimedia.org/r/309480

gerritbot added a comment.Sep 9 2016, 3:27 AM

Change 309480 merged by jenkins-bot:
Allow undoing edits that change content model if top

https://gerrit.wikimedia.org/r/309480

gerritbot added a comment.Sep 9 2016, 3:30 AM

Change 309490 merged by jenkins-bot:
API: When undoing an edit, allow overriding content model.

https://gerrit.wikimedia.org/r/309490

Bawolff mentioned this in T106195: MediaWiki gives error, when press undo after a contentmodelchange.Sep 9 2016, 4:18 AM
Bawolff merged a task: T106195: MediaWiki gives error, when press undo after a contentmodelchange.
Bawolff added subscribers: Luke081515, Bawolff, Quiddity and 3 others.
Legoktm closed this task as Resolved.Sep 9 2016, 4:27 AM
Legoktm reassigned this task from Legoktm to Bawolff.
• MZMcBride mentioned this in T72901: Users can change the content model of other users' user pages to CSS or JS.Sep 10 2016, 8:47 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
DannyS712 mentioned this in T251023: EditPage::getCurrentContent unexpectedly changes $currentModel and $currentFormat.Apr 25 2020, 10:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL