Maniphest T193027

Add a download on WiFi only setting for reading list users
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	RHo
	Apr 25 2018, 2:53 PM

Description

This is likely to be more pertinent as users start being able to add to reading lists from desktop browsers and multiple devices, for example, as seen in this OTRS report: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10661383

User story

As a reading list user who wants to conserve data usage, I want to be able to stop downloading synced articles to my device when so that I do not waste mobile data.

Proposed solution

Add a setting to the "Data usage" section of the app which enables users to "Download only over Wi-Fi".

Steps to QA

A. Articles on reading lists download only when WiFi is on

Go to Settings and enable "Download only on WiFi" setting
Turn off WiFi
Go to any article and save to a reading list. It is *expected* the article will not be downloaded since WiFi is unavailable.
Turn WiFi on. It is *expected* the article will be download since WiFi is turned back on.

B. Article downloading using data can be overridden manually

Go to Settings and enable "Download only on WiFi" setting
Turn off WiFi
Go to any article and save to a reading list. It is *expected* the article will not be downloaded since WiFi is unavailable.
Go to the reading list where the article was saved. Tap on the "downloading in progress" icon for that article. It is *expected* a dialog will appear asking if the user wants to proceed with downloading using mobile data.
If user selects 'yes', the article will be downloaded with mobile data.

Details

Subject	Repo	Branch	Lines +/-
Tweak: add a download on WiFi only setting for reading list users	apps/android/wikipedia	master	+13 -4
Follow-up to Wi-Fi download setting.	apps/android/wikipedia	master	+27 -48
Add a download on WiFi only setting for reading list users	apps/android/wikipedia	master	+126 -15

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T163596 [EPIC] Provide users with more bandwidth usage control
Resolved	cooltey	T193027 Add a download on WiFi only setting for reading list users
Invalid	None	T173417 Add a download on WiFi only setting for article packs

Event Timeline

RHo created this task.Apr 25 2018, 2:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2018, 2:53 PM

RHo added a subtask: T173417: Add a download on WiFi only setting for article packs.Apr 25 2018, 2:53 PM

RHo updated the task description. (Show Details)Apr 30 2018, 7:15 PM

RHo mentioned this in T163596: [EPIC] Provide users with more bandwidth usage control.May 1 2018, 12:40 PM

RHo added a parent task: T163596: [EPIC] Provide users with more bandwidth usage control.

LGoto set the point value for this task to 2.May 8 2018, 4:15 PM

LGoto edited projects, added Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog.

cooltey claimed this task.May 23 2018, 4:16 PM

cooltey moved this task from Backlog to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.

Hi, @RHo

Does this "Data usage" section has any description text for it?

hi @cooltey - let's can just add the setting without a description, seems pretty straightforward:

(note I updated the verbiage though to "Download only over Wi-Fi"

Sounds good, thanks.

cooltey updated the task description. (Show Details)May 24 2018, 9:16 PM

You can register a BroadcastReceiver for the app for notification of the wifi state, to automatically resume download when you are back on wifi. just a thought.

@TheDJ That's good! Thanks for sharing your idea.

Change 435065 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] [WIP] Download only over WiFi

https://gerrit.wikimedia.org/r/435065

gerritbot added a project: Patch-For-Review.May 24 2018, 11:08 PM

Hi @RHo, I have the following questions (the patch is not merged yet)

Question 1
When the state of Download only over Wi-Fi is ON, which icon should the app show to users?
The downloading in progress icon?

Screenshot_1527201593.png (1×1 px, 337 KB)

or the available to download icon on each article?

Screenshot_1527202073.png (1×1 px, 337 KB)

or... new icon?

Question 2
When the state of Download only over Wi-Fi is ON, should it be available for users to do the download the article action manually by clicking on the download icon or save all for offline?

In T193027#4230335, @cooltey wrote:

Hi @RHo, I have the following questions (the patch is not merged yet)

Question 1
When the state of Download only over Wi-Fi is ON, which icon should the app show to users?
The downloading in progress icon?

or the available to download icon on each article?

or... new icon?

hi @cooltey - the expectation is that the download will resume when the user is on Wi-Fi, so let's keep it as the downloading in progress icon. Thanks!

Question 2
When the state of Download only over Wi-Fi is ON, should it be available for users to do the download the article action manually by clicking on the download icon or save all for offline?

If the user has explicitly tapped the 'Download icon' or 'Save all for offline' even with this setting, can we show a dialog where they can choose to allow/cancel downloading using mobile data? Ie. something like this:

Confirm mobile data download.png (592×360 px, 28 KB)

@RHo Thanks, yes we can show dialogs to users.

Change 441092 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Follow-up to Wi-Fi download setting.

https://gerrit.wikimedia.org/r/441092

Change 435065 merged by jenkins-bot:
[apps/android/wikipedia@master] Add a download on WiFi only setting for reading list users

https://gerrit.wikimedia.org/r/435065

Change 441092 merged by jenkins-bot:
[apps/android/wikipedia@master] Follow-up to Wi-Fi download setting.

https://gerrit.wikimedia.org/r/441092

cooltey moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Jun 20 2018, 9:20 PM

Looks to me on 2.7.237-alpha-2018-06-27

• Vvjjkkii renamed this task from Add a download on WiFi only setting for reading list users to g9daaaaaaa.Jul 1 2018, 1:14 AM

• Vvjjkkii removed cooltey as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii removed the point value for this task.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii edited subscribers, added: cooltey; removed: gerritbot, Aklapper.

Sharvaniharan renamed this task from g9daaaaaaa to Add a download on WiFi only setting for reading list users.Jul 1 2018, 5:02 AM

Sharvaniharan assigned this task to cooltey.

Sharvaniharan lowered the priority of this task from High to Medium.

Sharvaniharan set the point value for this task to 2.

Sharvaniharan updated the task description. (Show Details)

Sharvaniharan removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Sharvaniharan added subscribers: Aklapper, gerritbot.

RHo updated the task description. (Show Details)Aug 2 2018, 4:32 PM

Hi @cooltey – the setting works but I'm not seeing the dialog to allow mobile data downloading as detailed in scenario B (see updated task description).

Expected: F18600475

Actual:

incorrect toast message saying that the article download is in progress.

In T193027#4240613, @RHo wrote:

In T193027#4230335, @cooltey wrote:

Hi @RHo, I have the following questions (the patch is not merged yet)
Question 2
When the state of Download only over Wi-Fi is ON, should it be available for users to do the download the article action manually by clicking on the download icon or save all for offline?

If the user has explicitly tapped the 'Download icon' or 'Save all for offline' even with this setting, can we show a dialog where they can choose to allow/cancel downloading using mobile data? Ie. something like this:

Thanks, @RHo

The dialog shows when the status of the article is not in "OFFLINE". We'll need to do Remove from offline and then try to click the download icon again to trigger the alert dialog of using mobile data.

I will add another logic that if the download is processing and click on the downloading icon will do the forced download.

Change 450166 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Tweak: add a download on WiFi only setting for reading list users

https://gerrit.wikimedia.org/r/450166

cooltey moved this task from Did not pass QA to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Aug 2 2018, 10:58 PM

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme); removed Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake).Aug 13 2018, 5:16 PM

Dbrant moved this task from Backlog to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Aug 13 2018, 5:54 PM

cooltey moved this task from Ready for dev to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Aug 14 2018, 6:22 PM

Change 450166 merged by jenkins-bot:
[apps/android/wikipedia@master] Tweak: add a download on WiFi only setting for reading list users

https://gerrit.wikimedia.org/r/450166

cooltey moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Aug 30 2018, 8:25 PM

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 30 2018, 8:25 PM

Works for me on 2.7.239-alpha-2018-09-04

Dbrant closed this task as Resolved.Nov 1 2018, 5:21 PM

• Charlotte closed subtask T173417: Add a download on WiFi only setting for article packs as Invalid.Nov 5 2019, 3:01 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2019, 3:11 PM

	F18600475: Confirm mobile data download.png
	May 29 2018, 6:45 PM

	F24444639: image.png
	Aug 2 2018, 4:37 PM

	F18513449: image.png
	May 24 2018, 8:21 PM

Add a download on WiFi only setting for reading list usersClosed, ResolvedPublic2 Estimated Story PointsActions