Maniphest T197157

New diffs show lines in the wrong order
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Jack_who_built_the_house
	Jun 13 2018, 5:20 PM

Description

It's the third time for the last 10 days that I see diffs basically spoiled: the lines in the right column are in the wrong order. Haven't found an existing task, maybe I searched badly.

https://ru.wikipedia.org/w/index.php?title=Шаблон:Результат_выборов&diff=93301102&oldid=58674687&diffmode=source

| page     = {{#if: {{{1|}}} | Википедия:Заявки на статус администратора/{{{1}}}{{#if: {{{номер|}}} | _{{{номер}}} }} }}

part is shown below

}}

while it's actually above

| template = Шаблон:Результат выборов администратора

https://ru.wikipedia.org/w/index.php?title=Шаблон:Кабинет_министров_Израиля&diff=prev&oldid=93086598

|стиль_групп     = text-align:center; background:{{Цвет/Израиль}};

is below

|класс_тела      = hlist

Actually it's above

|стиль_тела      =

https://ru.wikipedia.org/w/index.php?title=MediaWiki:Gadget-referenceTooltips.js&diff=prev&oldid=93294312

The same story with the line

					if ( mw.loader.getState( 'oojs-ui' ) !== 'ready' ) {

Details

	Subject	Repo	Branch	Lines +/-
	Streamline and document detectDissimilarChanges implementation	mediawiki/php/wikidiff2	master	+11 -20
	Fix misplaced ordering of lines in some diffs	mediawiki/php/wikidiff2	master	+232 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• jkroll	T197157 New diffs show lines in the wrong order
		Resolved		• jkroll	T200787 Import failing diff examples to test server

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Jack_who_built_the_house updated the task description. (Show Details)Jun 13 2018, 5:20 PM

SerDIDG awarded a token.Jun 13 2018, 5:22 PM

SerDIDG subscribed.

(I assume "new diff engine" refers to T195375.)

Bencemac subscribed.Jun 14 2018, 6:33 PM

Jack_who_built_the_house added a project: wikidiff2.Jun 15 2018, 6:32 PM

Jack_who_built_the_house renamed this task from New diff engine shows lines in the wrong order to New diffs show lines in the wrong order.Jun 15 2018, 6:36 PM

IKhitron subscribed.Jun 20 2018, 9:30 PM

Abiyoyo subscribed.Jun 20 2018, 9:37 PM

MBH subscribed.Jun 20 2018, 11:46 PM

• Vvjjkkii renamed this task from New diffs show lines in the wrong order to q2aaaaaaaa.Jul 1 2018, 1:04 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from q2aaaaaaaa to New diffs show lines in the wrong order.Jul 2 2018, 1:48 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Another example (from User:Larske at svwiki):

https://sv.wikipedia.org/w/index.php?title=Tom_Tits_Experiment&diff=next&oldid=43109604

Notice that the bullet points are ordered by year, but in the diff, the 2017 line appears out of order, after the 2018 line in the right column.

Larske subscribed.Jul 5 2018, 9:22 AM

Here is a smaller example showing the lines in the wrong order:

https://sv.wikipedia.org/w/index.php?title=Wikipedia:Sandl%C3%A5dan&diff=next&oldid=43235095

I guess T199770 and T195951 are duplicate?

Yes, pretty much looks like.

Aklapper merged tasks: T199770: [Regression] Inserted paragraph shown in wrong position in diff, T195951: Diffs erroneously show lines moved away.Jul 17 2018, 11:49 AM

Aklapper added subscribers: Schnark, matej_suchanek.

Daimona merged a task: T199222: Diff page shows diff lines in wrong order.Jul 17 2018, 11:52 AM

Daimona added subscribers: Marc, JeroenDeDauw.

We will have a look at this at least an investigation if the regression is caused by changes on wikidiff2. @jkroll

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-07-17 board.Jul 24 2018, 12:50 PM

WMDE-Fisch assigned this task to • jkroll.Jul 31 2018, 12:18 PM

WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-07-31.

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-07-31 board.

WMDE-Fisch mentioned this in T200787: Import failing diff examples to test server.Jul 31 2018, 12:23 PM

Change 450024 had a related patch set uploaded (by Jkroll; owner: Jkroll):
[mediawiki/php/wikidiff2@master] [WiP] Fix ordering of lines in some diffs

https://gerrit.wikimedia.org/r/450024

gerritbot added a project: Patch-For-Review.Aug 2 2018, 1:27 PM

Just for the record here, the bug was introduced with https://gerrit.wikimedia.org/r/#/c/mediawiki/php/wikidiff2/+/404293/

WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-07-31 board.Aug 14 2018, 7:58 AM

thiemowmde moved this task from Review to Doing on the WMDE-QWERTY-Sprint-2018-07-31 board.Aug 14 2018, 10:50 AM

WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-07-31 board.Aug 14 2018, 11:37 AM

WMDE-Fisch moved this task from Review to Doing on the WMDE-QWERTY-Sprint-2018-07-31 board.Aug 14 2018, 12:11 PM

WMDE-Fisch mentioned this in T201914: Add edge-case test to wikidiff2 C++ tests.Aug 14 2018, 12:25 PM

WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-08-14.Aug 14 2018, 12:28 PM

WMDE-Fisch changed the point value for this task from 5 to 8.

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-08-14 board.Aug 14 2018, 12:30 PM

JStrodt_WMDE closed subtask T200787: Import failing diff examples to test server as Resolved.Aug 14 2018, 12:56 PM

Change 452925 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/php/wikidiff2@master] Streamline and document detectDissimilarChanges implementation

https://gerrit.wikimedia.org/r/452925

thiemowmde moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-08-14 board.Aug 16 2018, 10:58 AM

T202190 is probably the same issue.

matej_suchanek merged a task: T202190: Shuffled lines in diff.Aug 19 2018, 11:22 AM

Change 450024 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Fix misplaced ordering of lines in some diffs

https://gerrit.wikimedia.org/r/450024

We could fix this issue and will start releasing and deploying the fixed version as soon as possible.

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-08-14 board.Aug 20 2018, 8:47 AM

Change 452925 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Streamline and document detectDissimilarChanges implementation

https://gerrit.wikimedia.org/r/452925

WMDE-Fisch mentioned this in T202301: Release and deploy wikidiff2 v1.7.3.Aug 20 2018, 3:42 PM

WMDE-Fisch mentioned this in T202399: Update wikidiff2 version on tests servers and rename version links.Aug 21 2018, 12:48 PM

matej_suchanek edited projects, added User-notice; removed Patch-For-Review.Aug 21 2018, 1:11 PM

matej_suchanek moved this task from To Triage to Announce in next Tech/News on the User-notice board.

@matej_suchanek This will be released with a new version of the wikidiff2 library, meaning outside of the train. The new wikidiff2 release is going to take some more time, see T202301. Can we postpone the announcement until we actually deploy?

Lea_WMDE reopened this task as Open.Aug 23 2018, 10:28 AM

My intention was to tell the folks this is a known problem, it was patched and the fix will be deployed soon. This would also give them the ability to track the progress since you already have a task for it. Re-adding User-notice, so that this issue is not forgotten and letting chief TN editors decide.

thanks for clarifying :)

Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Aug 23 2018, 5:34 PM

This can now be tested on the test server since T202399 is done:

https://wmde-wikidiff2-mobile.wmflabs.org/core/index.php?title=Svwiki-regression-test&type=revision&diff=15780&oldid=15779

Liuxinyu970226 awarded a token.Aug 27 2018, 10:07 PM

Liuxinyu970226 added a project: Russian-Sites.

Liuxinyu970226 subscribed.

Sakretsu subscribed.Aug 28 2018, 10:02 AM

Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-08-14 board.Aug 29 2018, 9:00 AM

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Aug 30 2018, 8:52 PM

The deployment of the bugfixed version for that issue was just finished today so the problem should be resolved. I checked the linked diffs and they seemed all fine now.

Liuxinyu970226 unsubscribed.Sep 4 2018, 2:18 PM

Pipetricker unsubscribed.Sep 4 2018, 9:37 PM

RandomDSdevel awarded a token.Oct 1 2018, 1:38 AM

matej_suchanek unsubscribed.Nov 24 2018, 1:24 PM

Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:47 PM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM