Page MenuHomePhabricator

Display notification text for incoming notification
Closed, ResolvedPublic

Description

As now polling is used to update the notification count on header icons. So, if there are new notifications a snippet showing relevant information regarding the new notification should appear temporarily using the mw.notify() library.

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
InvalidNone
InvalidWikinaut
OpenNone
OpenFeatureNone
Resolved demon
DuplicateNone
DeclinedQuiddity
ResolvedNone
ResolvedGalorefitz
DeclinedNone
OpenFeatureNone
Resolvedkostajh
OpenNone
StalledNone
OpenNone
ResolvedShivanshbindal9
ResolvedShivanshbindal9

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 524520 had a related patch set uploaded (by Shivanshbindal9; owner: shivanshbindal9):
[mediawiki/extensions/Echo@master] Display notification text for incoming notification

https://gerrit.wikimedia.org/r/524520

JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.
JTannerWMF subscribed.

Hey @Catrope can you please let us know how to proceed with this task?

This is a GSoC task. Moving to External since that's what we appear to have done with other GSoC tasks.

Change 524520 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Display notification text for incoming notification

https://gerrit.wikimedia.org/r/524520

@Shivanshbindal9 I think this needs a follow-up, as HTML in notifications is not rendered (see screenshot)

image.png (684×1 px, 62 KB)

Some other thoughts:

  • I'd like to consider either making the notifications sticky (click to dismiss) or show them for a longer amount of time, as the current number of seconds is not really long enough to look at and think about what you've seen before it's disappeared. For me, anyway :)
  • Clicking the notification doesn't do anything. Ideally (@Catrope or @Mooeypoo might have other preferences for this), clicking the notification would open up the notifications panel

Change 531135 had a related patch set uploaded (by Shivanshbindal9; owner: shivanshbindal9):
[mediawiki/extensions/Echo@master] Render HTML in notification snippet

https://gerrit.wikimedia.org/r/531135

Change 531135 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Render HTML in notification snippet

https://gerrit.wikimedia.org/r/531135

  • Clicking the notification doesn't do anything. Ideally (@Catrope or @Mooeypoo might have other preferences for this), clicking the notification would open up the notifications panel

Yes, I think opening the notification panel when the little notification bubble is clicked would be a good idea.

(I'm being bold and closing this task)