Page MenuHomePhabricator

Disable native OpenSearch suggestions in Wikibase wikis
Open, Needs TriagePublic

Description

Reproduce:

  1. Open a page (preferably an Wikibase entity page)
  2. Refresh the page
  3. Quickly put some text to Wikidata search box, like this: https://commons.wikimedia.org/wiki/File:Element_search_in_Wikidata_(Catalan).png, before the JavaScript is loaded (in entity pages, once JavaScript is loaded the edit statement buttons are shown)

Result:

The native OpenSearch suggestions is shown, overlapping the Wikibase search box.

Expected:

The native search box should be disabled.

Note:

T190454#4092077 proposed to integrate the Wikibase search box to the native search box.

Event Timeline

dcausse subscribed.

Removing Discovery-Search as this is purely UI related. As noted in the description (T190454#4092077) the ultimate goal would be to unify all these autocomplete APIs.

Note “Search for pages containing” hides the first search result, so the most relevant one.

I can confirm on Wikipedia. Does anyone have an update?

Gehel subscribed.

This seems related to the Wikidata UI itself. Maybe someone on WMDE side could have a look.

OpenSearch support was intentionally added in the past based on user requests to allow people to add for example search keywords in Firefox. So I do not want to remove that again. However as the ticket description says we will look at the suggestion issue as part of T190454.

I also sometimes get it on Wikipedia by typing in things before JavaScript loads (you get OpenSearch) and then continue typing after V22 search loads. Both boxes appear

OpenSearch support was intentionally added in the past based on user requests to allow people to add for example search keywords in Firefox. So I do not want to remove that again. However as the ticket description says we will look at the suggestion issue as part of T190454.

Note I do not mean to disable the API; I only mean the search box in Wikidata should not load OpenSearch suggestions.

Jdlrobson moved this task from Incoming to Tracking on the Web-Team-Backlog board.
Jdlrobson subscribed.

What assistance is needed from the web team? My understanding is Wikidata has its own implementation of search on legacy Vector so I think any fixes will need to be done by the WMDE team. Let me know if you need any help from us.

@Jdlrobson in T249989#9330640 a user reports that a similar problem sometimes happen with the new vector 2022 search completion box on a wiki that is not wikidata, could the custom wikibase search box and the new one from vector 2022 share the same mechanics to override the "old" opensearch search completion box?

@aliu does this happen in safe mode? Vector 2022 shouldn't be loading Opensearch (the mediawiki.searchSuggest module) under any circumstances. I can't replicate this myself on English Wikipedia

Well, it only happened a couple times in one day. I've never encountered it since then. Maybe something in between accidentally fixed it.

@Lydia_Pintscher it seems that the problem isn't serious on other wikis, but it might still be an issue on Wikidata. I'll let you decide what you want to do with it.

It appeared several times on Wikipedia recently