| • Dmantena | |
| Aug 11 2021, 8:35 PM |
| F34940832: image.png | |
| Feb 2 2022, 6:56 PM |
See Figma for empty state mocks (they are in a vertical column), except for the "No alert subscriptions" empty state. That task is covered in https://phabricator.wikimedia.org/T291003.
https://phabricator.wikimedia.org/T287298
https://phabricator.wikimedia.org/T288662
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T278838 Mobile user communication issues ([[Wikipedia:Mobile communication bugs]]) | |||
| Resolved | • JMinor | T274404 Support notifications on the iOS app | |||
| Resolved | • JMinor | T287308 Notification Center UI | |||
| Resolved | • JMinor | T288668 [Notifications] Add empty state view to Notifications Center |
I know we'll need to tweak this screen further once filters are implemented, so moving this back into ready for dev for now. The basic empty state while importing notifications is done.
Note: looks like our current version of main isn't populating the subtitle when an empty state is displayed due to a filter. Moving back into Ready for Development to investigate.
FYI @cmadeo @OTichonova - at some point we updated the empty state string "You have no unread messages" to "You have no messages". Since the notifications center is capable of displaying both read and unread messages, an empty state indicates neither type is available to display. Can you update the Figma mocks for QA so we don't have a bug on this?
Note: looks like our current version of main isn't populating the subtitle when an empty state is displayed due to a filter. Moving back into Ready for Development to investigate.
I think this is working now, I may have been confused earlier because we removed the read status filter from counting towards this subtitle from the user testing feedback.
There's one last thing remaining to develop for this ticket. We need to show and update the subtitle if the user has turned off all of their inbox projects. So the final logic for the subtitle display and text will be:
Read status: any value (read, unread, or all)
Types: any value (all OFF, all ON, some OFF)
Inbox: 0 checked
Subtitle displays and says ""Add projects to see more messages".
Read status: any value (read, unread, or all)
Types: all ON
Inbox: 1+ checked
No subtitle displays. Empty state will only show title "You have no messages" - This is done.
Read status: read, unread, or all
Types: one or more OFF
Inbox: 1+ checked
Subtitle displays and says "Modify {n} filters to see more messages" with {n} being the number of types they have toggled OFF. - This is done.
@cmadeo Please let me know if I'm wrong on any of this. Thanks!
Here are the original comments with this logic:
https://phabricator.wikimedia.org/T301126#7691556
https://phabricator.wikimedia.org/T301126#7697570