Page MenuHomePhabricator

[QA task] Section level image suggestions - testing in beta
Closed, ResolvedPublic

Description

Issues

(6) (from https://phabricator.wikimedia.org/T336549#8897571)

Screen Shot 2023-06-01 at 3.26.07 PM.png (168×1 px, 34 KB)

minimize suggestion, only available on mobile.
AI-image-suggest-collapsed.png (53×360 px, 4 KB)
collapsed suggestion mode

The following title is not fixed:

<span class="mw-ge-recommendedImageToolbarDialog-title">(growthexperiments-addimage-inspector-title: 1)</span>

Screen Shot 2023-06-05 at 6.01.42 PM.png (1×1 px, 396 KB)
Screen Shot 2023-06-05 at 6.05.48 PM.png (818×1 px, 306 KB)

DONE

(1) filed as T338283 - the issue seems to be happening only on cswiki beatlabs: "Suggestions are no longer available on this article." message is displayed with the Console showing the following:

You've exceeded your rate limit. Please wait some time and try again.
jQuery runScript cssHandle flushCssBuffer

(2) cswiki betalbs works as expected. The message was displayed frequently on enwiki betalabs due to test env limitations. Another reason for "Suggestions are no longer available on this article." message:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Martin_Scorsese&gesuggestededit=1&veaction=edit
Section 2 already contains an image: ./File:Martin_Scorsese_03.jpg

(3) (see https://phabricator.wikimedia.org/T337900#8894489)

mobile - the intro tour doesn't display images
Screen Shot 2023-06-01 at 2.25.19 PM.png (1×732 px, 129 KB)

Note: Other intro tours (Add article image and Add link) display images correctly

(4) (see https://phabricator.wikimedia.org/T337900#8894701) Tags for section level img suggestion edits are not specific:

Screen Shot 2023-05-31 at 5.02.25 PM.png (320×2 px, 146 KB)

Done: the tag is:"newcomer task section image suggestion"
Screen Shot 2023-06-05 at 6.14.07 PM.png (244×1 px, 84 KB)

(5) (see https://phabricator.wikimedia.org/T337900#8897438) On mobile the label for SLIS in SE module doesn't match the same title in Select types of edits overlay list. Note: all other types of tasks do not display that discrepancy.

Select types of edits Homepage
Screen Shot 2023-06-01 at 9.44.17 AM.png (1×1 px, 280 KB)
Screen Shot 2023-06-01 at 9.03.02 AM.png (1×816 px, 109 KB)

This is a little it tricky - on narrower mobile screens the title (if we the title will be as on the list, i.e. "Add an image to an article section" would be cut off and only displayed as: "Add an image to an article se..." which might be hard to distinguis with "Add an image to an unillustrated article", see below:

Screen Shot 2023-06-01 at 9.05.23 AM.png (1×852 px, 99 KB)

(7) per https://phabricator.wikimedia.org/T337900#8904295 (from https://phabricator.wikimedia.org/T336549#8897571) The rejection dialog is not reachable?

Edit summary for rejected image and caption
Edit summary reject.png (640×360 px, 18 KB)
Edit summary rejected.png (900×1 px, 199 KB)
Edit summary for rejected image (Follows the same specifications as Add an image structured task)

(8) Quality gate (from https://phabricator.wikimedia.org/T336550#8897636)
Special:EditGrowthConfig on betalabs does have Add a suggested section image section, see for example: eswiki betalabs Special:EditGrowthConfig. But the section lacks The maximum number of section-level "Add an image" suggested tasks a newcomer can complete daily field.

Event Timeline

(1) Quite often "Suggestions are no longer available on this article." message is displayed.
...
... However, Special:EditGrowthConfig doesn't have a quality gate set for Add a suggested section image.

It defaults to 25/day, like image recommendations. You can set it to a large number and the error should go away.

(2) Another reason for "Suggestions are no longer available on this article." message:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Martin_Scorsese&gesuggestededit=1&veaction=edit
Section 2 already contains an image: ./File:Martin_Scorsese_03.jpg

I think this is just enwiki getting images more quickly. These errors seem legit; on other beta wikis they happen less often.

(3) On mobile, when a section level img suggestion is unavailable, a user will see the intro tour without pictures

Isn't that happening for all tasks? I think the mobile images are just not available yet (per rEGREdfd34b338a35: Section images: add onboarding dialog; cc @Sgs)

(4) Tags for section level img suggestion edits are not specific

In general task submission is not done yet (T337767: Section-level images: task submission). I think tags are supposed to work though. Will check.

In general task submission is not done yet (T337767: Section-level images: task submission). I think tags are supposed to work though. Will check.

Should be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/925702.

Change 925702 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Section images: Expand SectionImageRecommendationTaskTypeHandler

https://gerrit.wikimedia.org/r/925702

(1) Quite often "Suggestions are no longer available on this article." message is displayed.
...
... However, Special:EditGrowthConfig doesn't have a quality gate set for Add a suggested section image.

It defaults to 25/day, like image recommendations. You can set it to a large number and the error should go away.

Thanks, @Tgr! I'll re-check - the problem that I saw: the message appeared after just the few edits.

Thanks, @Tgr! I'll re-check - the problem that I saw: the message appeared after just the few edits.

Hm, that would be a bug. Can you share in the engineering Slack channel when that happens next time so someone can diagnose it?

(5) On mobile the task type for suggested section level image task type on Homepage doesn't match the same title in Select types of edits overlay list. Note: all other types of tasks do not display that discrepancy.

Not sure I understand - are you referring the the card text saying "add a suggested section image" instead of "add an image to an article section"?
I imagine that will be ironed out in T335714: Section-level images: finalize copy and QQQ descriptions for TranslateWiki.net.

This is a little it tricky - on narrower mobile screens the title (if we the title will be as on the list, i.e. "Add an image to an article section" would be cut off and only displayed as: "Add an image to an article se..." which might be hard to distinguis with "Add an image to an unillustrated article", see below:

T335924: Section-level images: article-level and section-level image thumbnails for Suggested edits will help with that.

(5) On mobile the task type for suggested section level image task type on Homepage doesn't match the same title in Select types of edits overlay list. Note: all other types of tasks do not display that discrepancy.

Not sure I understand - are you referring the the card text saying "add a suggested section image" instead of "add an image to an article section"?
I imagine that will be ironed out in T335714: Section-level images: finalize copy and QQQ descriptions for TranslateWiki.net.

Thx, @Tgr - it was exactly that: "add a suggested section image" is displayed instead of "add an image to an article section". I'll update this task at the end of the day and report in the slack of whatever issues would be found.

Change 925702 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: Expand SectionImageRecommendationTaskTypeHandler

https://gerrit.wikimedia.org/r/925702

(7) (from https://phabricator.wikimedia.org/T336549#8897571) The rejection dialog is not reachable?

Per IRL discussion, the rejection dialog is reachable but the summary/save dialog doesn't show up afterwards, and this is probably intentional and matches Add Image workflow (we should look at the relevant Add Image task just to make sure).

(8) (from https://phabricator.wikimedia.org/T336550#8897636)
Special:EditGrowthConfig on betalabs does have Add a suggested section image section, see for example:eswiki betalabs Special:EditGrowthConfig. But the section lacks The maximum number of section-level "Add an image" suggested tasks a newcomer can complete daily. field.

Done in T336550: Section-Level Images: quality gate.

Per IRL discussion, the rejection dialog is reachable but the summary/save dialog doesn't show up afterwards, and this is probably intentional and matches Add Image workflow (we should look at the relevant Add Image task just to make sure).

This is indeed per spec and was done in T295929: Add an image: After rejecting an image, the user should be taken directly to the post-edit dialog.

@Tgr - thank you for such detailed responses! I've re-checked and updated the description.

To summarize the outstanding issues:

  • #6 mw-ge-recommendedImageToolbarDialog-title still shows "Add an image to an unillustrated article"
  • #3 - the intro tour on mobile doesn't have images
  • #6 mw-ge-recommendedImageToolbarDialog-title still shows "Add an image to an unillustrated article"

Right, and it also says "Add this image to the start of the article?". Updating those is part of the (admittedly confusingly scoped) T335209: Section-level images: suggestions mode.

  • #3 - the intro tour on mobile doesn't have images

That's tracked in T335207: Section-level images: onboarding dialog.

I'll move this to In Progress for now (it doesn't need code review anymore) but the work is happening in other tasks.

  • #3 - the intro tour on mobile doesn't have images

That's tracked in T335207: Section-level images: onboarding dialog.

The related conversation to get mobile and RTL assets is happening T332925, I will add them when provided.

Closing this task as Resolved.

Three outstanding issues will be tracked in the respective tickets: