Page MenuHomePhabricator

[M] Going to a revision history page for unsupported pages shows an error
Closed, ResolvedPublicBUG REPORT

Assigned To
None
Authored By
JTannerWMF
Aug 3 2023, 11:19 PM
Referenced Files
F42769276: Screenshot 2024-03-19 at 4.06.23 PM
Mar 19 2024, 9:10 PM
F42769268: Screenshot 2024-03-19 at 4.06.18 PM
Mar 19 2024, 9:10 PM
F42769229: Screenshot 2024-03-19 at 4.06.16 PM
Mar 19 2024, 9:10 PM
F42769214: Screenshot 2024-03-19 at 4.06.11 PM
Mar 19 2024, 9:10 PM
F41563984: IMG_6862.png
Dec 6 2023, 12:47 AM
F41563985: IMG_6860.png
Dec 6 2023, 12:47 AM
F41563986: IMG_6858.png
Dec 6 2023, 12:47 AM
F41563987: IMG_6861.png
Dec 6 2023, 12:47 AM

Description

Steps to replicate the issue (include links if applicable):

  • Trigger a notification or click on a notification to Village Pump on EN Wikipedia
  • Click the diff for the notification
  • Go to the overflow menu and click article history

What happens?:

Error message

What should have happened instead?:

Send users outside of the app to the unsupported page

Software version (skip for WMF-hosted wikis like Wikipedia):
7.4.0 in Test Flight

Other information (browser name/version, screenshots, etc.):

IMG_6344.PNG (2×1 px, 729 KB)

File.jpg (2×1 px, 131 KB)

IMG_6345.PNG (2×1 px, 247 KB)

Testing tips

https://phabricator.wikimedia.org/T343494#9644089

Event Timeline

@JTannerWMF Any chance you can provide more precise repro steps to trigger an in-app Meta wiki notification in the style of what you're encountering? There certainly seem to be some diff history URL title parsing/navigation issues, but I'd like to be sure I'm addressing what you're encountering.

Hey @Dmantena below are the screens in order of action:

IMG_6858.png (2×1 px, 214 KB)

IMG_6860.png (2×1 px, 152 KB)

IMG_6861.png (2×1 px, 242 KB)

IMG_6862.png (2×1 px, 100 KB)

JTannerWMF raised the priority of this task from Low to Medium.Jan 23 2024, 11:05 PM

Estimation notes: Might be challenging to reproduce.

Seddon renamed this task from Going to a revision history page for unsupported pages shows an error to [M] Going to a revision history page for unsupported pages shows an error.Jan 25 2024, 6:40 PM

Note from Jazmin: If the namespace isn't supported, just use the web interface.

To test: I tried to get a little closer to the error steps by @mentioning another account of mine on https://test.wikipedia.org/wiki/Wikipedia:Village_pump. Below are screenshots showing the same flow with the bug fixed:

Screenshot 2024-03-19 at 4.06.11 PM (1×559 px, 206 KB)

Screenshot 2024-03-19 at 4.06.16 PM (1×559 px, 219 KB)

Screenshot 2024-03-19 at 4.06.18 PM (1×559 px, 260 KB)

Screenshot 2024-03-19 at 4.06.23 PM (1×559 px, 264 KB)