[XL] Address outstanding issues for Watchlist
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	JTannerWMF
	Oct 2 2023, 10:38 PM

Description

Background
There were important improvements for Watchlist that didn't make it into 7.4.2. due to timing. Those tasks are still importnat, as the lead engineer for Watchlist, this task is for @Dmantena to make the improvements that didn't make it into the 7.4.2 release.

Tasks to Complete

Hyperlink the titles of the articles on the diff screen so that users can go to the article they are viewing the edit for T352326
Provide users an entry point to update update their languages in the filter view. (info contained within current ticket - T347915, T356794)
Address weird behavior with date alignment on diff screen when there isn't an edit summary T347425
Finalize Accessibility Audit for Diff View T343582 T347761
Bug with visiting unsupported Revision History pages T343494
Remove WKMenuButtonDelegate T347433

References

Screenshot_20231002-183424.png (2×1 px, 103 KB)

Screenshot_20231002-183721.png (2×1 px, 97 KB)

Designs for adding a language:


Filter view	Language selection [1]

[1] Reuses the modal from Settings → My languages → Add another language

Related Objects
Search...

Status	Assigned	Task
Resolved	JTannerWMF	T334212 [Sub-Epic] Watchlist for iOS
Resolved	None	T347915 [XL] Address outstanding issues for Watchlist
Resolved	None	T352326 [Subtask] Watchlist outstanding - hyperlink article title on diff
Resolved	JTannerWMF	T356794 [L] Watchlist - add entry point to update update their languages in the filter view.

Event Timeline

JTannerWMF created this task.Oct 2 2023, 10:38 PM

JTannerWMF updated the task description. (Show Details)

I've attached some examples of the implementation on Android as a reference. the Update app languages just takes you to settings where you can modify languages.

I think the issue around the edit summary is because on Android the structure is date>Username>Summary, so it doesn't matter if the summary is variable because the other two fixed items are always there.

JTannerWMF assigned this task to • Dmantena.Oct 2 2023, 10:42 PM

JTannerWMF moved this task from Tasks from Product Backlog to Ready for Development on the iOS Release FY2023-24 (Archive) board.

JTannerWMF updated the task description. (Show Details)Oct 4 2023, 2:41 PM

JTannerWMF triaged this task as Medium priority.Oct 4 2023, 3:11 PM

JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

JTannerWMF updated the task description. (Show Details)Oct 10 2023, 7:03 PM

JTannerWMF updated the task description. (Show Details)Oct 10 2023, 7:07 PM

• Dmantena removed • Dmantena as the assignee of this task.Oct 17 2023, 7:40 PM

• Dmantena claimed this task.Nov 1 2023, 7:35 PM

• Dmantena moved this task from Ready for Development to Doing on the iOS Release FY2023-24 (Archive) board.

Provide users an entry point to update update their languages in the filter view.

@scblr Apologies if I'm missing this in Figma, but I can't locate the iOS designs for this. Are there iOS designs for this somewhere?

I’ll have a look @Dmantena and will provide designs next week 👍

In T347915#9299849, @Dmantena wrote:

Provide users an entry point to update update their languages in the filter view.

@scblr Apologies if I'm missing this in Figma, but I can't locate the iOS designs for this. Are there iOS designs for this somewhere?

Here you go @Dmantena 👇


Filter view	Language selection [1]

[1] Reuses the modal from Settings → My languages → Add another language

scblr updated the task description. (Show Details)Nov 3 2023, 3:35 PM

• Dmantena updated the task description. (Show Details)Nov 3 2023, 7:12 PM

PR for header link: https://github.com/wikimedia/wikipedia-ios/pull/4677

• Dmantena updated the task description. (Show Details)Nov 29 2023, 9:21 PM

Tsevener updated the task description. (Show Details)Nov 29 2023, 11:06 PM

Seddon updated the task description. (Show Details)Dec 12 2023, 10:35 PM

Tsevener closed subtask T352326: [Subtask] Watchlist outstanding - hyperlink article title on diff as Resolved.Dec 14 2023, 6:12 PM

Here're updates on this task.

Provide users an entry point to update update their languages in the filter view.

I have two WIP branches up for this work:

https://github.com/wikimedia/wikipedia-ios/tree/T347915/1-languages-modal - this adds the plumbing between the main client app and the watchlist component in the components framework to be able to present a client-side view controller over a watchlist components view controller
https://github.com/wikimedia/wikipedia-ios/tree/T347915/2-row-action - this adds an update to the WKFormSectionSelectView form view to support multi selection sections with accessory rows. This allows adding arbitrary selectable "button" rows in a multi selection form section (in order to support the design intent of displaying "Add language" at the bottom of the Wikipedias section).

I've tried rewriting this a few times, and while this has been the least friction to WKFormView approach so far, I'm not particularly happy with it and I'm entirely open to a different approach – feel free to tear it up as needed. I just wanted to leave something as close to functional as possible before I was out which should hopefully be straightforward for anyone to pick up.

The remaining work on it are:

Replace the preferred language modal that's displayed with WMFLanguagesViewController (TODO's in code indicate where).
Reload the watchlist filter view model/view after user selects new language.

Additionally, while working on it I discovered this bug (that also appears in production):

Non-latin language name not displaying in Watchlist filters: add Simplified Chinese to your languages, open Watchlist filters, and note that the row name is empty for that language

As for the additional items listed:

Finalize Accessibility Audit for Diff View T343582 T347761
Bug with visiting unsupported Revision History pages T343494

https://phabricator.wikimedia.org/T343582 - blocked, changes to how VoiceOver announces diffs are still pending design feedback, VoiceOver support pending T347761
https://phabricator.wikimedia.org/T347761 - open for development, confirmed issue
https://phabricator.wikimedia.org/T343494 - open for development, confirmed issue (namespace parsing for URL issue)

Have a great holiday break!

JTannerWMF updated the task description. (Show Details)Jan 18 2024, 1:11 AM

Seddon moved this task from Ready for Development to Needs Engineering Sync on the iOS Release FY2023-24 (Archive) board.Jan 24 2024, 3:18 PM

Seddon updated the task description. (Show Details)Jan 25 2024, 6:33 PM

Seddon updated the task description. (Show Details)

Seddon moved this task from Needs Engineering Sync to Blocked or Waiting on the iOS Release FY2023-24 (Archive) board.

JTannerWMF updated the task description. (Show Details)Jan 30 2024, 7:52 PM

Seddon moved this task from Blocked or Waiting to Ready for Development on the iOS Release FY2023-24 (Archive) board.Feb 5 2024, 3:22 PM

Seddon moved this task from Ready for Development to Blocked or Waiting on the iOS Release FY2023-24 (Archive) board.Feb 6 2024, 6:18 PM

Tsevener moved this task from Blocked or Waiting to Epics In Progress on the iOS Release FY2023-24 (Archive) board.Feb 6 2024, 8:55 PM

Tsevener mentioned this in T356794: [L] Watchlist - add entry point to update update their languages in the filter view..Feb 7 2024, 6:02 PM

• Dmantena updated the task description. (Show Details)Feb 20 2024, 5:45 PM