Page MenuHomePhabricator

Refine typography settings interface
Closed, ResolvedPublicDesign

Assigned To
Authored By
JScherer-WMF
Sep 25 2023, 3:31 PM
Referenced Files
F38217532: Reading theme anons unhide.png
Oct 12 2023, 9:19 PM
F38217531: Reading theme anons hidden.png
Oct 12 2023, 9:19 PM
F38217534: Reading theme settings anons.png
Oct 12 2023, 9:19 PM
F38217530: Reading theme logged in unhide.png
Oct 12 2023, 9:19 PM
F38217529: Reading theme logged hidden.png
Oct 12 2023, 9:19 PM
F38217535: Reading theme logged in with tools.png
Oct 12 2023, 9:19 PM
F38217533: Reading theme logged in no tools.png
Oct 12 2023, 9:19 PM
F37976212: Dark.png
Oct 4 2023, 8:42 PM

Description

Design a configuration interface for reading theme preferences.

Figma file for reference

Event Timeline

Jdlrobson triaged this task as Medium priority.Sep 25 2023, 6:53 PM
ovasileva raised the priority of this task from Medium to High.Sep 25 2023, 7:12 PM
JScherer-WMF changed the task status from Open to In Progress.Sep 26 2023, 4:42 PM

Video outlining proposed designs and validation approach:
https://youtu.be/Z44M_0W_IFc

Figma:
https://www.figma.com/file/84uThsPg9ayvZmnbshyP7e/Vector-2022-updates?type=design&node-id=627%3A23846&mode=design&t=OkBZPtA4TS0tl85j-1

Proposal

An A/B test with consolidated reading theme settings in the main menu as one treatment, and another treatment with the night/day mode button broken out as part of the editor tools. The intention behind the A/B test is to determine whether readers will fast-flip between day and night modes depending on context. Placing the toggle in a more prominent place is a better affordance for quickly changing polarization theme depending on your reading context
Proposed success criteria for t2 would be much higher adoption of the setting compared to t1 and Control. Failure criteria is if dark mode is used as a “set and forget” setting.

Treatment 1 showing consolidated reading theme settings

Base.png (922×1 px, 388 KB)

Treatment 1 showing consolidated reading theme with density settings open

Base-1.png (923×1 px, 398 KB)

Treatment 2 showing Night/Day mode button broken out into editor tools

Base-2.png (922×1 px, 388 KB)

Treatment 2 showing Night mode

Dark.png (922×1 px, 368 KB)

I'll be getting design team feedback on these this week. @ovasileva @Jdlrobson @sgrabarczuk @Jdrewniak I would love your feedback and guidance on next steps.

Thanks for putting this together @JScherer-WMF! The video walkthrough is v helpful for understanding these designs. I had some initial questions/feedback

  1. In the video walkthrough you mentioned the main menu made sense from an IA perspective because the main menu has some settings and reader related stuff, including languages. I've always had the impression that the main menu was more focused on editor links (i.e. the contribute section), and infrequently accessed site wide links. I believe that's one of the reasons why its hidden by default for anon users, because that content isnt as relevant for readers. Languages also arent inside the main menu, I think we moved them out because we didn't want settings inside the main menu. Right now there's a notification reminding people of the new location of languages, but as I understand that will eventually be removed. I'm not sure how much of a concern this is, but I'm wondering if the usage of the main menu goes against some of those IA changes we've made in the past
  1. Is there a proposed solution for the decreased discoverability for anon users who will not see the main menu by default? Or is treatment 2 the main intervention to at least have dark mode easily accessible?
  1. For treatment 2, will this design need to be adapted if we want more themes (i.e. sepia)? And even with just dark mode, many sites have an auto setting based off their OS. I'm wondering if we should consider these cases and future extensibility with the single button toggle.
  1. I was also thinking about the IA for treatment 2. Since legacy vector, that section of the page toolbar is for "page actions" ('edit' & 'view history' link to sub pages of an article, and 'watch/unwatch' is an article page specific action). In my mind, switching themes is a site wide interface setting, and isn't specific to a page. This is probably a minor thing for most users, but I think its important to point out this IA also impacts accessibility. That area of the page is a navigation landmark region that's currently labelled "page actions". These regions allows screenreader users to quickly access sections of the page. In my mind the most accessible experience for screenreader users is for all the reader settings to be located in a single place under a navigation landmark region with a descriptive label like 'interface settings' or something similar. I could imagine it being hard for screenreader users to have the theme setting separated from the rest of the reader settings and under the 'page actions' region. To note, most people using dark mode wont be using a screenreader, but there plenty of people who have limited vision that rely on a combination of sight and screenreaders, so this use case isn't unheard of.
  1. I'm thinking about the collapsible radio buttons, to me it seems like a custom UI component, almost like a combination between a disclosure widget and a radio button. I know we have patterns that look similar like in the TOC and the collapsible headings on mobile, but each of these cases are actually quite different when it comes to their implementation and accessibility. Similarly, I think there's nuance with this design that will likely need more research and testing. Some questions that come to mind, does clicking the legends (i.e. density, color) also show/hide the radio buttons, or is it only the arrows that does that? Is there accessibility/HTML concerns with having the radio buttons hidden, but the fieldset and legend elements still visible? Should we implement this with a button and custom JS like we did with the ToC, or could we use <details>. None of these questions are sure blockers or things that we cant work around by any means, but I wanted to acknowledging that custom UI elements could take a bit more time to figure out compared to something in Codex for example.

Thank you for the video @JScherer-WMF - it was super helpful to get an idea of the proposal. A couple of notes (very similar to what @bwang said above):

Treatment 1:

  • I really like the simplicity and it fits the overall style of the page
  • Introducing settings in a navigational menu. We don’t currently have that distinction, but is it a distinction we might want to have? All the other items in the menu are navigational. Wondering if it might be confusing to have both in a single menu/what other effects might this mix have in the long term.
  • I have similar concerns to what @bwang said above. The main menu collapsed is by default which might hurt discoverability. We could potentially think of some tutorial or popup on first launch that helps with this. However, the main menu overall is used very infrequently as the links in there are not relevant to most casual readers, which is one of the reasons we collapsed it in the first place.

Treatment 2:

  • I like this, might draw some more attention on the edit button (so we should probably look at edit rates if we go with this
  • I'm not sure how we want to treat the overall navigational hierarchy. Right now that bar is focused on per-page actions (which is a separation we introduced within Vector 2022). Adding global actions here might be a bit confusing to readers/break out of that pattern.
  • Small concern on adding more options in that bar (it’s already quite long), especially with the new label on the watch icon

Thanks for the feedback @ovasileva and @bwang !

I did another iteration on this today based on your feedback and the feedback of the design team. I walked through the new approach and rationale in this video.

Logged in, no tools

Reading theme logged in no tools.png (923×1 px, 345 KB)

Logged in, with tools

Reading theme logged in with tools.png (923×1 px, 362 KB)

Logged-in, hidden

Reading theme logged hidden.png (923×1 px, 336 KB)

Logged-in, unhide

Reading theme logged in unhide.png (923×1 px, 314 KB)

Logged out

Reading theme settings anons.png (922×1 px, 345 KB)

Logged-out, hidden

Reading theme anons hidden.png (922×1 px, 336 KB)

Logged-out, unhide

Reading theme anons unhide.png (922×1 px, 354 KB)

@ovasileva does this treatment align with our conversation yesterday and satisfy the feedback above?
@Jdlrobson does this raise any red flags for navigation that you're aware of?

Figma file for reference

Outstanding items that need to be taken care of still:

  1. Icon for hidden theme menu
  2. I want to put these in the main menu in Minerva, but I'm still unclear on how that would impact scope given that we'd need to move the existing text settings.

This looks great, thanks @JScherer-WMF! A couple of notes:

  1. Discoverability of the hide button - with the new default-open proposal, our expectation would be that most logged-out users set their preferred theme and then hide the menu. We should check that the hide action is easily discoverable and understandable.
  2. +1 on collapsing into the three dot menu be a bit awkward/breaking out of the existing pattern. I like the broken-out component idea within the other menu.

Justin says we can mark this as done. The only thing we've missing is a settings icon for desktop web.