| JScherer-WMF | |
| Nov 6 2023, 5:59 PM |
| F41483623: Reading theme logged in no tools - skeleton.png | |
| Nov 10 2023, 4:59 PM |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Jdrewniak | T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations | |||
| Open | Jdrewniak | T313828 [EPIC] Typography: improve typography and allow for variable typography settings | |||
| Duplicate | Florian | T50946 Add font size adjustment feature | |||
| Duplicate | Jdlrobson | T91201 [GOAL] Accessibility settings/preferences on desktop and mobile | |||
| Duplicate | Jdlrobson | T345359 [Goal] Allow logged-out and logged-in users to set preferred typography | |||
| Resolved | bwang | T350612 Design a skeleton loading state for reading settings interface |
In course of this, please note T311874: Skeleton: Add Skeleton loader component to Codex.
Thanks for this @Volker_E I was going to ask if we have an existing component that I can use!
@Jdlrobson This is what the reading theme menu looks like with that skeleton style added.
There's an animation spec'd for it in that ticket which looks like this.
What other information do you need for implementation?
Where will this settings interface go? Would it be an standalone or something that pop-ups also with the tools menu?
Thanks for the question! :)
I think the answer to your question is that the reading settings will be standalone. The details on the settings menu designs are in T347309. In that ticket there is an unlisted Youtube video where I walk through the proposed designs.
Thanks for the answer. I really don't get the obsession of the design team to move things to the right when we should have the left menu more relevant, instead of less relevant. But the solution proposed goes with that strange moves. At least, is terribly consistent.
@ovasileva Do we already have a ticket for implementing the skeleton? I will meet with the implementing dev when it's time for implementation. Moving to sign off.
I checked in with @JScherer-WMF and he confirmed that rendering the full form just with disabled radio buttons (https://phabricator.wikimedia.org/F41514107) would be preferrable to a skeleton loader which hides the content. Instead of making a new task for implementing the skeleton loader, I made https://phabricator.wikimedia.org/T351562 for the new disabled radio button design