Page MenuHomePhabricator

Move MoodBar user preference to "Appearance" tab
Closed, ResolvedPublic

Description

TL;DR: Per bug 52757 and bug 52759

Currently, [[mw:Extension:MoodBar]] adds a user preference under the "Misc" tab:

  • Disable Moodbar

This user preference should either be removed entirely (allowing users to hide the UI with a JavaScript gadget or custom CSS) or moved to the "Appearance" user preferences tab (as the other extensions have done).


Version: unspecified
Severity: normal

Details

Reference
bz65018

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:08 AM
bzimport set Reference to bz65018.

(In reply to Quiddity from comment #0)

This user preference should either be removed entirely (allowing users to
hide the UI with a JavaScript gadget or custom CSS)

No, Having a proper user preference is better here. Telling users to disable extensions via js and css mods is a crappy thing to do.

This is a very invasive extension, it's probably best to leave the preference. I'm not sure how it relates to "appearance" though.

Sorry, ignore the bit about "removed entirely" (I was copying the text from bug 52757).

(In reply to Nemo from comment #2)

This is a very invasive extension, it's probably best to leave the
preference. I'm not sure how it relates to "appearance" though.

A) Because it changes the widgets visible on every page.
B) Because there's nowhere else for it to go! :)

Note: It's only in current use on 5 wikis: [[mw:MoodBar#Status]]

Death to the "Misc" tab!

This request seems fine, marking it with the "easy" keyword accordingly (this is a trivial one-line change, I imagine). Quiddity: careful with the copying and pasting. ;-)

Tangentially, it may make sense to file a bug about searching all MediaWiki extensions in Git for other references to the "Misc" user preference tab.

Note: It's only "easy" if it's non-controversial.

Change 135179 had a related patch set uploaded by Gerrit Patch Uploader:
Move MoodBar preference to "Appearance" tab

https://gerrit.wikimedia.org/r/135179

Change 135179 merged by jenkins-bot:
Move MoodBar preference to "Appearance" tab

https://gerrit.wikimedia.org/r/135179