Page MenuHomePhabricator
Create Task
Maniphest T84996

Buttons requiring a rationale on Curation toolbar appear to be broken
Closed, ResolvedPublic
Actions

Description

The buttons on the curation toolbar that require a rationale, currently result in the message, "Tag prod is missing required parameter".

(Was Clicking the "Tag" and "mark as reviewed" buttons currently does nothing.)

Details

SubjectRepoBranchLines +/-
Fix PageTriage JS dialog parametermediawiki/extensions/PageTriagewmf/1.25wmf13+2 -2
Fix PageTriage JS dialog parametermediawiki/extensions/PageTriagewmf/1.25wmf12+2 -2
Fix PageTriage JS dialog parametermediawiki/extensions/PageTriagemaster+2 -2
Replace .live function calls with .onmediawiki/extensions/PageTriagewmf/1.25wmf13+14 -10
Replace .live function calls with .onmediawiki/extensions/PageTriagemaster+14 -10
Replace .live function calls with .onmediawiki/extensions/PageTriagewmf/1.25wmf12+14 -10
Customize query in gerrit

Revisions and Commits

rMEXT MediaWiki Extensions
rMEXTb07bf24a23af Updated mediawiki/extensions Project: mediawiki/extensions/PageTriage…
rMEXT2843b334f211 Updated mediawiki/extensions Project: mediawiki/extensions/PageTriage…
rEPTR extension-PageTriage
rEPTR7c69d16aa03a Replace .live function calls with .on
rEPTR85f0b1d7f333 Replace .live function calls with .on
rEPTR6e3aa2ae32f3 Fix PageTriage JS dialog parameter
rEPTRf379c1eef361 Fix PageTriage JS dialog parameter
rEPTR0d5e57d63954 Fix PageTriage JS dialog parameter
rEPTR8ec08788c004 Replace .live function calls with .on
rEPTRedcd9890367a Replace .live function calls with .on
rEPTRdebd31b9709d Replace .live function calls with .on

Related Objects
Search...

Event Timeline

Swpb created this task.Dec 19 2014, 1:46 PM
Swpb raised the priority of this task from to Unbreak Now!.
Swpb updated the task description. (Show Details)
Swpb added a project: PageTriage.
Swpb changed Security from none to None.
Swpb subscribed.
Swpb lowered the priority of this task from Unbreak Now! to High.Dec 19 2014, 3:04 PM
Swpb raised the priority of this task from High to Unbreak Now!.
Swpb added a comment.Dec 19 2014, 3:43 PM

Automatic messaging of the page creator is also broken.

Quiddity subscribed.Dec 19 2014, 6:04 PM

Further notes onwiki at https://en.wikipedia.org/wiki/Wikipedia_talk:Page_Curation#Curation_Toolbar

• Mattflaschen-WMF mentioned this in T85022: Audit deployed Collaboration team extensions for jQuery 1.11 upgrade issues.Dec 19 2014, 9:03 PM
gerritbot added a project: Patch-For-Review.Dec 19 2014, 10:30 PM

Change 181191 had a related patch set uploaded (by Mattflaschen):
Replace .live function calls with .on

https://gerrit.wikimedia.org/r/181191

Patch-For-Review

• Mattflaschen-WMF claimed this task.Dec 19 2014, 10:31 PM
• Mattflaschen-WMF added a project: Collaboration-Team-Triage.
• Mattflaschen-WMF moved this task from Untriaged to Code Review on the Collaboration-Team-Triage board.
• Mattflaschen-WMF subscribed.
tommorris subscribed.Dec 19 2014, 11:01 PM

Quiddity said on-wiki that there is a code freeze until January 7. This is currently preventing anyone doing new page patrol. Over the Christmas/New Years break, lots of volunteers may want to spend some of their hard-earned time off working on the wiki, perhaps by patrolling the new page feed. Not being able to do this is pretty major breakage and is very disruptive to the running of the 'pedia.

Quiddity updated the task description. (Show Details)Dec 20 2014, 12:59 AM
gerritbot added a comment.Dec 20 2014, 1:31 AM

Change 181191 merged by jenkins-bot:
Replace .live function calls with .on

https://gerrit.wikimedia.org/r/181191

Legoktm closed this task as Resolved.Dec 20 2014, 1:33 AM
Legoktm added a commit: rEPTRdebd31b9709d: Replace .live function calls with .on.

Closed by commit rEPTRdebd31b9709d.

gerritbot added a comment.Dec 20 2014, 2:12 AM

Change 181226 had a related patch set uploaded (by Mattflaschen):
Replace .live function calls with .on

https://gerrit.wikimedia.org/r/181226

Patch-For-Review

gerritbot added a comment.Dec 20 2014, 2:14 AM

Change 181226 merged by jenkins-bot:
Replace .live function calls with .on

https://gerrit.wikimedia.org/r/181226

• Mattflaschen-WMF added a commit: rEPTRedcd9890367a: Replace .live function calls with .on.Dec 20 2014, 2:14 AM
gerritbot added a comment.Dec 20 2014, 2:23 AM

Change 181227 had a related patch set uploaded (by Mattflaschen):
Replace .live function calls with .on

https://gerrit.wikimedia.org/r/181227

Patch-For-Review

gerritbot added a comment.Dec 20 2014, 2:24 AM

Change 181227 merged by jenkins-bot:
Replace .live function calls with .on

https://gerrit.wikimedia.org/r/181227

• Mattflaschen-WMF added a commit: rEPTR8ec08788c004: Replace .live function calls with .on.Dec 20 2014, 2:24 AM
Quiddity added a comment.Dec 20 2014, 4:33 AM

I asked for confirmation from users that everything was good, and
Imaginatorium replied that:

No. I still get "Tag speedy deletion-duplicate article is missing required parameter." when I try to enter the article name. I'm not sure if this is exactly the same problem as above, but I cannot seem to do anything with the curation tool as of a couple of days ago. Imaginatorium (talk) 03:49, 20 December 2014 (UTC)

Swpb added a comment.Dec 22 2014, 6:00 PM

The issue is not entirely fixed. Proposed deletion still reports "Tag subst:prod is missing required parameter" when the parameter has been provided. I have not confirmed all the other functionalities.

Quiddity added a comment.Dec 22 2014, 6:48 PM

Kudpung wrote, "the button for adding the required rationales for COPYVIO and PROD is in fact dead".
Confirmed at testwiki:

9TmuXue.png (415×592 px, 61 KB)

There are no useful details in webconsole, even with ?debug=1

Quiddity reopened this task as Open.Dec 22 2014, 6:48 PM
Quiddity renamed this task from "Tag" and "mark as reviewed" buttons on Curation toolbar appear to be broken. to Buttons requiring a rationale on Curation toolbar appear to be broken..Dec 22 2014, 7:02 PM
Quiddity updated the task description. (Show Details)
kaldari subscribed.Dec 22 2014, 10:09 PM
gerritbot added a comment.Dec 23 2014, 1:23 AM

Change 181532 had a related patch set uploaded (by Spage):
Fix PageTriage JS dialog parameter

https://gerrit.wikimedia.org/r/181532

Patch-For-Review

• Spage subscribed.Dec 23 2014, 1:30 AM

If all the remaining problems like with user-entered deletion details, then I hope my patch fixes them. Thanks for curating over the holidays!

gerritbot added a comment.Dec 23 2014, 1:32 AM

Change 181532 merged by jenkins-bot:
Fix PageTriage JS dialog parameter

https://gerrit.wikimedia.org/r/181532

• Spage closed this task as Resolved.Dec 23 2014, 1:37 AM
• Spage added a commit: rEPTR0d5e57d63954: Fix PageTriage JS dialog parameter.

Closed by commit rEPTR0d5e57d63954.

• Spage reopened this task as Open.Dec 23 2014, 3:30 AM
• Spage removed • Mattflaschen-WMF as the assignee of this task.
• Spage removed a project: Patch-For-Review.
• Spage added a subscriber: WMF-Server-Backports.
He7d3r renamed this task from Buttons requiring a rationale on Curation toolbar appear to be broken. to Buttons requiring a rationale on Curation toolbar appear to be broken.Dec 23 2014, 7:04 PM
• Mattflaschen-WMF closed this task as Resolved.Dec 24 2014, 6:59 PM
gerritbot added a project: Patch-For-Review.Dec 24 2014, 7:15 PM

Change 181752 had a related patch set uploaded (by Spage):
Fix PageTriage JS dialog parameter

https://gerrit.wikimedia.org/r/181752

Patch-For-Review

gerritbot added a comment.Dec 24 2014, 7:16 PM

Change 181753 had a related patch set uploaded (by Spage):
Fix PageTriage JS dialog parameter

https://gerrit.wikimedia.org/r/181753

Patch-For-Review

gerritbot added a comment.Dec 24 2014, 7:32 PM

Change 181753 merged by jenkins-bot:
Fix PageTriage JS dialog parameter

https://gerrit.wikimedia.org/r/181753

gerritbot added a comment.Dec 24 2014, 7:33 PM

Change 181752 merged by jenkins-bot:
Fix PageTriage JS dialog parameter

https://gerrit.wikimedia.org/r/181752

• Spage added a commit: rEPTRf379c1eef361: Fix PageTriage JS dialog parameter.Dec 24 2014, 7:34 PM
• Spage added a commit: rEPTR6e3aa2ae32f3: Fix PageTriage JS dialog parameter.
• Spage moved this task from Code Review to Blocked with questions on the Collaboration-Team-Triage board.Dec 24 2014, 7:57 PM
Ricordisamoa subscribed.Dec 25 2014, 1:50 AM
• Spage moved this task from Blocked with questions to Done (see also Status=Resolved) on the Collaboration-Team-Triage board.Dec 25 2014, 3:53 AM
• Spage added a comment.Dec 25 2014, 4:35 AM

ori told us to "Just do it", so we backported on Christmas eve.

Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM
RandomDSdevel awarded a token.Mar 4 2015, 7:52 PM
• Mattflaschen-WMF added a commit: rMEXT2843b334f211: Updated mediawiki/extensions Project: mediawiki/extensions/PageTriage….Mar 11 2015, 4:38 AM
• Spage added a commit: rMEXTb07bf24a23af: Updated mediawiki/extensions Project: mediawiki/extensions/PageTriage….Mar 11 2015, 4:38 AM
Legoktm added a commit: rEPTR7c69d16aa03a: Replace .live function calls with .on.Apr 28 2016, 12:54 AM
• Mattflaschen-WMF added a commit: rEPTR85f0b1d7f333: Replace .live function calls with .on.Apr 28 2016, 12:54 AM
Restricted Application added subscribers: Southparkfan, Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptApr 28 2016, 12:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL