Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F27312488
T210329.patch
Huji (Huji Lee)
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Authored By
Huji
Nov 25 2018, 9:07 PM
2018-11-25 21:07:16 (UTC+0)
Size
2 KB
Referenced Files
None
Subscribers
None
T210329.patch
View Options
diff --git a/includes/api/ApiQueryAbuseLog.php b/includes/api/ApiQueryAbuseLog.php
index 31e06a25..ccff6fb9 100644
--- a/includes/api/ApiQueryAbuseLog.php
+++ b/includes/api/ApiQueryAbuseLog.php
@@ -56,7 +56,6 @@ class ApiQueryAbuseLog extends ApiQueryBase {
$fld_ids = isset( $prop['ids'] );
$fld_filter = isset( $prop['filter'] );
$fld_user = isset( $prop['user'] );
- $fld_ip = isset( $prop['ip'] );
$fld_title = isset( $prop['title'] );
$fld_action = isset( $prop['action'] );
$fld_details = isset( $prop['details'] );
@@ -67,9 +66,6 @@ class ApiQueryAbuseLog extends ApiQueryBase {
$isCentral = $this->getConfig()->get( 'AbuseFilterIsCentral' );
$fld_wiki = $isCentral && isset( $prop['wiki'] );
- if ( $fld_ip ) {
- $this->checkUserRightsAny( 'abusefilter-private' );
- }
if ( $fld_details ) {
$this->checkUserRightsAny( 'abusefilter-log-detail' );
}
@@ -99,7 +95,6 @@ class ApiQueryAbuseLog extends ApiQueryBase {
$this->addFields( 'afl_filter' );
$this->addFieldsIf( 'afl_id', $fld_ids );
$this->addFieldsIf( 'afl_user_text', $fld_user );
- $this->addFieldsIf( 'afl_ip', $fld_ip );
$this->addFieldsIf( [ 'afl_namespace', 'afl_title' ], $fld_title );
$this->addFieldsIf( 'afl_action', $fld_action );
$this->addFieldsIf( 'afl_var_dump', $fld_details );
@@ -195,9 +190,6 @@ class ApiQueryAbuseLog extends ApiQueryBase {
if ( $fld_user ) {
$entry['user'] = $row->afl_user_text;
}
- if ( $fld_ip ) {
- $entry['ip'] = $row->afl_ip;
- }
if ( $fld_wiki ) {
$entry['wiki'] = $row->afl_wiki;
}
@@ -291,7 +283,6 @@ class ApiQueryAbuseLog extends ApiQueryBase {
'ids',
'filter',
'user',
- 'ip',
'title',
'action',
'details',
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
6734244
Default Alt Text
T210329.patch (2 KB)
Attached To
Mode
T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API
Attached
Detach File
Event Timeline
Log In to Comment