Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3307876
0001-Don-t-render-wikidata-description-as-HTML.patch
Jdlrobson (Jon Robson)
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Authored By
Jdlrobson
Feb 3 2016, 6:58 PM
2016-02-03 18:58:10 (UTC+0)
Size
1 KB
Referenced Files
None
Subscribers
None
0001-Don-t-render-wikidata-description-as-HTML.patch
View Options
From c03afe65eb6d23524462d48f336ef296f4be40d0 Mon Sep 17 00:00:00 2001
From: jdlrobson <jdlrobson@gmail.com>
Date: Wed, 3 Feb 2016 10:52:04 -0800
Subject: [PATCH] Don't render wikidata description as HTML
There is no reason to treat the wikidata description as HTML.
Remember three braces = render as HTML which can be problematic with
user inputted content. Use two braces when rendering.
Change-Id: I0291bf04e6d2f7ef62843b1c77cfb7123690e7ca
---
resources/mobile.pagelist/PageListItem.hogan | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/resources/mobile.pagelist/PageListItem.hogan b/resources/mobile.pagelist/PageListItem.hogan
index d50c5d0..6109448 100644
--- a/resources/mobile.pagelist/PageListItem.hogan
+++ b/resources/mobile.pagelist/PageListItem.hogan
@@ -10,7 +10,7 @@
{{#thumbnail}}data-style="background-image: url( {{thumbnail.source}} )"{{/thumbnail}}></div>
<h3>{{{displayTitle}}}</h3>
{{#wikidataDescription}}
- <div class="wikidata-description">{{{wikidataDescription}}}</div>
+ <div class="wikidata-description">{{wikidataDescription}}</div>
{{/wikidataDescription}}
{{#lastModified}}
<div class="info">{{lastModifiedMsg 'hi'}} {{lastModified}}</div>
--
2.5.4 (Apple Git-61)
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
3315162
Default Alt Text
0001-Don-t-render-wikidata-description-as-HTML.patch (1 KB)
Attached To
Mode
T125684: Wikidata description on mobile search and Special:Nearby is not escaped
Attached
Detach File
Event Timeline
Log In to Comment